Bugzilla – Attachment 98388 Details for
Bug 24338
CASH is missing from the default payment_types
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24338: (QA follow-up) Make update idempotent
Bug-24338-QA-follow-up-Make-update-idempotent.patch (text/plain), 1.51 KB, created by
Martin Renvoize (ashimema)
on 2020-02-04 13:20:01 UTC
(
hide
)
Description:
Bug 24338: (QA follow-up) Make update idempotent
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-02-04 13:20:01 UTC
Size:
1.51 KB
patch
obsolete
>From 2e4ba0f2791c3dbd15998223fe280e45f826e181 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 4 Feb 2020 13:19:18 +0000 >Subject: [PATCH] Bug 24338: (QA follow-up) Make update idempotent > >--- > .../data/mysql/atomicupdate/bug_24338.perl | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_24338.perl b/installer/data/mysql/atomicupdate/bug_24338.perl >index bf154169ae..b4483240f8 100644 >--- a/installer/data/mysql/atomicupdate/bug_24338.perl >+++ b/installer/data/mysql/atomicupdate/bug_24338.perl >@@ -1,11 +1,18 @@ > $DBversion = 'XXX'; # will be replaced by the RM > if( CheckVersion( $DBversion ) ) { >- $dbh->do(qq{ >- INSERT INTO >- authorised_values (category,authorised_value,lib, lib_opac) >- VALUES >- ('PAYMENT_TYPE','CASH','Cash','Cash') >- }); >+ my $exists; >+ eval { $exists = $dbh->do("SELECT 1 FROM authorised_values WHERE category = 'PAYMENT_TYPE' AND authorised_value = 'CASH'"); }; >+ if ( $exists == 0 ) { >+ print "Adding CASH payment type\n"; >+ $dbh->do(qq{ >+ INSERT INTO >+ authorised_values (category,authorised_value,lib, lib_opac) >+ VALUES >+ ('PAYMENT_TYPE','CASH','Cash','Cash') >+ }); >+ } else { >+ print "CASH payment type already found\n"; >+ } > > SetVersion( $DBversion ); > print "Upgrade to $DBversion done (Bug 24338 - Add 'CASH' to default 'PAYMENT_TYPE')\n"; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24338
:
97972
|
98381
|
98388
|
98412
|
98413
|
98490
|
98491
|
98504
|
98505