View | Details | Raw Unified | Return to bug 24526
Collapse All | Expand All

(-)a/misc/cronjobs/automatic_renewals.pl (-8 / +6 lines)
Lines 89-102 while ( my $auto_renew = $auto_renews->next ) { Link Here
89
    # CanBookBeRenewed returns 'auto_renew' when the renewal should be done by this script
89
    # CanBookBeRenewed returns 'auto_renew' when the renewal should be done by this script
90
    my ( $ok, $error ) = CanBookBeRenewed( $auto_renew->borrowernumber, $auto_renew->itemnumber );
90
    my ( $ok, $error ) = CanBookBeRenewed( $auto_renew->borrowernumber, $auto_renew->itemnumber );
91
    if ( $error eq 'auto_renew' ) {
91
    if ( $error eq 'auto_renew' ) {
92
        if ($verbose) {
93
            say sprintf "Issue id: %s for borrower: %s and item: %s ". ( $commit ? 'will' : 'would') . " be renewed.",
94
              $auto_renew->issue_id, $auto_renew->borrowernumber, $auto_renew->itemnumber;
95
        }
92
        if ($commit){
96
        if ($commit){
93
            my $date_due = AddRenewal( $auto_renew->borrowernumber, $auto_renew->itemnumber, $auto_renew->branchcode );
97
            my $date_due = AddRenewal( $auto_renew->borrowernumber, $auto_renew->itemnumber, $auto_renew->branchcode );
94
            $auto_renew->auto_renew_error(undef)->store;
98
            $auto_renew->auto_renew_error(undef)->store;
95
        }
99
        }
96
        if ( $verbose ){
97
            print "Issue id: " . $auto_renew->issue_id . " for borrower: " . $auto_renew->borrowernumber . " and item: " . $auto_renew->itemnumber;
98
            $commit ? print " will be renewed.\n" : print " would be renewed.\n";
99
        }
100
        push @{ $report{ $auto_renew->borrowernumber } }, $auto_renew;
100
        push @{ $report{ $auto_renew->borrowernumber } }, $auto_renew;
101
    } elsif ( $error eq 'too_many'
101
    } elsif ( $error eq 'too_many'
102
        or $error eq 'on_reserve'
102
        or $error eq 'on_reserve'
Lines 108-116 while ( my $auto_renew = $auto_renews->next ) { Link Here
108
        or $error eq 'auto_too_soon'
108
        or $error eq 'auto_too_soon'
109
        or $error eq 'item_denied_renewal' ) {
109
        or $error eq 'item_denied_renewal' ) {
110
        if ( $verbose ) {
110
        if ( $verbose ) {
111
            print "Issue id: " . $auto_renew->issue_id . " for borrower: " . $auto_renew->borrowernumber . " and item: " . $auto_renew->itemnumber;
111
            say sprintf "Issue id: %s for borrower: %s and item: %s ". ( $commit ? 'will' : 'would') . " not be renewed. (%s)",
112
            $commit ? print " will not be renewed " : print " would not be renewed ";
112
              $auto_renew->issue_id, $auto_renew->borrowernumber, $auto_renew->itemnumber, $error;
113
            print "($error)\n";
114
        }
113
        }
115
        if ( not $auto_renew->auto_renew_error or $error ne $auto_renew->auto_renew_error ) {
114
        if ( not $auto_renew->auto_renew_error or $error ne $auto_renew->auto_renew_error ) {
116
            $auto_renew->auto_renew_error($error)->store if $commit;
115
            $auto_renew->auto_renew_error($error)->store if $commit;
117
- 

Return to bug 24526