Bugzilla – Attachment 98642 Details for
Bug 18933
Unable to set SMS number in OPAC messaging preferences to empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18933: Allow OPAC messaging SMS number to be set to empty
Bug-18933-Allow-OPAC-messaging-SMS-number-to-be-se.patch (text/plain), 1.78 KB, created by
David Nind
on 2020-02-10 10:17:23 UTC
(
hide
)
Description:
Bug 18933: Allow OPAC messaging SMS number to be set to empty
Filename:
MIME Type:
Creator:
David Nind
Created:
2020-02-10 10:17:23 UTC
Size:
1.78 KB
patch
obsolete
>From b6f202c8b0e6f3d507fb942acf5cf3c07e4741cf Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Sun, 9 Feb 2020 21:55:01 +0000 >Subject: [PATCH] Bug 18933: Allow OPAC messaging SMS number to be set to empty > >To test: >1) Ensure EnhancedMessagingPreferences is enabled and >EnhancedMessagingPreferencesOPAC is set to Show. Set SMSSendDriver to >Email >2) Log in to OPAC, go to your messaging tab >3) Set an SMS number if you havent already >4) Try to remove it (set to empty) >5) Notice that it says the number has been updated, but it has not >been set to empty >6) Apply patch and refresh page >7) Attempt to set the number to empty >8) Confirm this is successful > >Sponsored-by: Catalyst IT > >Signed-off-by: David Nind <david@davidnind.com> >--- > opac/opac-messaging.pl | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > >diff --git a/opac/opac-messaging.pl b/opac/opac-messaging.pl >index 8a6996ae18..496c2addec 100755 >--- a/opac/opac-messaging.pl >+++ b/opac/opac-messaging.pl >@@ -57,13 +57,10 @@ my $messaging_options = C4::Members::Messaging::GetMessagingOptions(); > if ( defined $query->param('modify') && $query->param('modify') eq 'yes' ) { > my $sms = $query->param('SMSnumber'); > my $sms_provider_id = $query->param('sms_provider_id'); >- if ( defined $sms && ( $patron->smsalertnumber // '' ) ne $sms >- or ( $patron->sms_provider_id // '' ) ne $sms_provider_id ) { >- $patron->set({ >- smsalertnumber => $sms, >- sms_provider_id => $sms_provider_id, >- })->store; >- } >+ $patron->set({ >+ smsalertnumber => $sms, >+ sms_provider_id => $sms_provider_id, >+ })->store; > > C4::Form::MessagingPreferences::handle_form_action($query, { borrowernumber => $patron->borrowernumber }, $template); > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18933
:
65014
|
98628
|
98642
|
99133