Bugzilla – Attachment 9872 Details for
Bug 8176
$sqlwhere is undefined in C4::Serials in GetSubscriptions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere
Bug-8176-SIGNED-OFF-Assign-an-intial-value-to-sqlw.patch (text/plain), 998 bytes, created by
Jonathan Druart
on 2012-06-01 09:32:57 UTC
(
hide
)
Description:
Bug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-06-01 09:32:57 UTC
Size:
998 bytes
patch
obsolete
>From 628b23522ebe30d944599b5b3d51707444cf4313 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Fri, 1 Jun 2012 08:10:21 +0100 >Subject: [PATCH] Bug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere > >warnings in log because of undefined value in >string concatenation >variable should be initialized to empty string rather >than left undefined > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Removes a warning in logs >--- > C4/Serials.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 20ad706..af5c833 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -566,7 +566,7 @@ sub GetSubscriptions { > LEFT JOIN biblioitems ON biblio.biblionumber = biblioitems.biblionumber > ); > my @bind_params; >- my $sqlwhere; >+ my $sqlwhere = q{}; > if ($biblionumber) { > $sqlwhere = " WHERE biblio.biblionumber=?"; > push @bind_params, $biblionumber; >-- >1.7.7.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8176
:
9867
| 9872 |
10003