View | Details | Raw Unified | Return to bug 24083
Collapse All | Expand All

(-)a/t/db_dependent/Circulation.t (-1 / +9 lines)
Lines 274-280 Koha::CirculationRules->set_rules( Link Here
274
274
275
my ( $reused_itemnumber_1, $reused_itemnumber_2 );
275
my ( $reused_itemnumber_1, $reused_itemnumber_2 );
276
subtest "CanBookBeRenewed tests" => sub {
276
subtest "CanBookBeRenewed tests" => sub {
277
    plan tests => 77;
277
    plan tests => 79;
278
278
279
    C4::Context->set_preference('ItemsDeniedRenewal','');
279
    C4::Context->set_preference('ItemsDeniedRenewal','');
280
    # Generate test biblio
280
    # Generate test biblio
Lines 1133-1138 subtest "CanBookBeRenewed tests" => sub { Link Here
1133
    is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
1133
    is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
1134
    is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
1134
    is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
1135
1135
1136
    # Too many unseen renewals
1137
    $dbh->do('UPDATE issuingrules SET unseen_renewals_allowed = 2, renewalsallowed = 10');
1138
    $dbh->do('UPDATE issues SET unseen_renewals = 2 where borrowernumber = ? AND itemnumber = ?', undef, ($renewing_borrowernumber, $item_1->itemnumber));
1139
    ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
1140
    is( $renewokay, 0, 'Cannot renew, 0 unseen renewals allowed');
1141
    is( $error, 'too_unseen', 'Cannot renew, returned code is too_unseen');
1142
    $dbh->do('UPDATE issuingrules SET norenewalbefore = NULL, renewalsallowed = 0');
1143
1136
    # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
1144
    # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
1137
    t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
1145
    t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
1138
    t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
1146
    t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
(-)a/t/db_dependent/Circulation/issue.t (-1 / +13 lines)
Lines 32-37 use Koha::Checkouts; Link Here
32
use Koha::Database;
32
use Koha::Database;
33
use Koha::DateUtils;
33
use Koha::DateUtils;
34
use Koha::Holds;
34
use Koha::Holds;
35
use Koha::IssuingRules;
35
use Koha::Items;
36
use Koha::Items;
36
use Koha::Library;
37
use Koha::Library;
37
use Koha::Patrons;
38
use Koha::Patrons;
Lines 261-267 my $datedue4 = AddRenewal( $opac_renew_issue->{borrowernumber}, $opac_renew_issu Link Here
261
$stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef,  $opac_renew_issue->{borrowernumber},  $opac_renew_issue->{itemnumber}, "Stavromula" );
262
$stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef,  $opac_renew_issue->{borrowernumber},  $opac_renew_issue->{itemnumber}, "Stavromula" );
262
ok( $stat, "Bug 18572 - 'Bug 18572 - OpacRenewalBranch is now respected" );
263
ok( $stat, "Bug 18572 - 'Bug 18572 - OpacRenewalBranch is now respected" );
263
264
265
# Unseen rewnewals
266
t::lib::Mocks::mock_preference('UnseenRenewals', 1);
264
267
268
# Does an unseen renewal increment the issue's count
269
my ( $unseen_before ) = ( C4::Circulation::GetRenewCount( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber} ) )[3];
270
AddRenewal( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber}, $branchcode_1, undef, undef, 0 );
271
my ( $unseen_after ) = ( C4::Circulation::GetRenewCount( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber} ) )[3];
272
is( $unseen_after, $unseen_before + 1, 'unseen_renewals increments' );
273
274
# Does a seen renewal reset the unseen count
275
AddRenewal( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber}, $branchcode_1, undef, undef, 1 );
276
my ( $unseen_reset ) = ( C4::Circulation::GetRenewCount( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber} ) )[3];
277
is( $unseen_reset, 0, 'seen renewal resets the unseen count' );
265
278
266
#Test GetBiblioIssues
279
#Test GetBiblioIssues
267
is( GetBiblioIssues(), undef, "GetBiblio Issues without parameters" );
280
is( GetBiblioIssues(), undef, "GetBiblio Issues without parameters" );
268
- 

Return to bug 24083