Bugzilla – Attachment 98922 Details for
Bug 19791
Patron Modification log redirects to circulation page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19791: Keep user in circ when viewing patron's logs
Bug-19791-Keep-user-in-circ-when-viewing-patrons-l.patch (text/plain), 5.54 KB, created by
Jonathan Druart
on 2020-02-14 10:48:13 UTC
(
hide
)
Description:
Bug 19791: Keep user in circ when viewing patron's logs
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-02-14 10:48:13 UTC
Size:
5.54 KB
patch
obsolete
>From a76333082e9bfbe998694cb13e9ef7d204ecb2ad Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 14 Feb 2020 11:44:44 +0100 >Subject: [PATCH] Bug 19791: Keep user in circ when viewing patron's logs > >When a librarian is viewing the log for a given patron (tab "modification log" >from the circulation module), the "object" and "modules" parameter can >be modified. It does not make sense, we should stay in the circulation >module and avoid those fields to be modified. > >Test plan: >- Modify several patrons (in order to have several modification logs) >- Go to the modification log tab of one of them >- Notice that the "Object" input is not a "Borrowernumber" labelled >input and that you cannot modify it. >Also notice that the "modules" is hidden. >- Go to the log viewer tool and notice that the view is still the same >as before this patch. >--- > .../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 47 +++++++++++++--------- > 1 file changed, 28 insertions(+), 19 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >index 3d46a56d1c..6e2632c6e3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >@@ -98,23 +98,27 @@ > <label for="user">Librarian:</label> > <input type="text" name="user" id="user" value="[% user | html %]" /> > </li> >- <li> >- <label for="modules">Modules:</label> >- <select name="modules" id="modules" multiple="multiple"> >- [% UNLESS modules %] >- <option value="" selected="selected">All</option> >- [% ELSE %] >- <option value="">All</option> >- [% END %] >- [% FOREACH modx IN [ 'CATALOGUING' 'AUTHORITIES' 'MEMBERS' 'ACQUISITIONS' 'SERIAL' 'HOLDS' 'ILL' 'CIRCULATION' 'LETTER' 'FINES' 'SYSTEMPREFERENCE' 'CRONJOBS', 'REPORTS' ] %] >- [% IF modules.grep(modx).size %] >- <option value="[% modx | html %]" selected="selected">[% PROCESS translate_log_module module=modx %]</option> >+ [% UNLESS src == "circ" %] >+ <li> >+ <label for="modules">Modules:</label> >+ <select name="modules" id="modules" multiple="multiple"> >+ [% UNLESS modules %] >+ <option value="" selected="selected">All</option> > [% ELSE %] >- <option value="[% modx | html %]">[% PROCESS translate_log_module module=modx %]</option> >+ <option value="">All</option> > [% END %] >- [% END %] >- </select> >- </li> >+ [% FOREACH modx IN [ 'CATALOGUING' 'AUTHORITIES' 'MEMBERS' 'ACQUISITIONS' 'SERIAL' 'HOLDS' 'ILL' 'CIRCULATION' 'LETTER' 'FINES' 'SYSTEMPREFERENCE' 'CRONJOBS', 'REPORTS' ] %] >+ [% IF modules.grep(modx).size %] >+ <option value="[% modx | html %]" selected="selected">[% PROCESS translate_log_module module=modx %]</option> >+ [% ELSE %] >+ <option value="[% modx | html %]">[% PROCESS translate_log_module module=modx %]</option> >+ [% END %] >+ [% END %] >+ </select> >+ </li> >+ [% ELSE %] >+ <input type="hidden" name="modules" value="MEMBERS" /> >+ [% END %] > <li> > <label for="actions">Actions:</label> > <select name="actions" id="actions" multiple="multiple"> >@@ -133,10 +137,15 @@ > [% END %] > </select> > </li> >- <li> >- <label for="object">Object: </label> >- <input type="text" id="object" name="object" value="[% object | html %]" /> >- </li> >+ <li> >+ [% IF src == 'circ' %] >+ <label for="object">Borrowernumber: </label> >+ <input type="text" id="object" name="object" value="[% object | html %]" readonly="readonly" title="This field cannot be modified from the circulation module." /> >+ [% ELSE %] >+ <label for="object">Object: </label> >+ <input type="text" id="object" name="object" value="[% object | html %]" /> >+ [% END %] >+ </li> > <li> > <label for="info">Info:</label> > <input type="text" id="info" name="info" value="[% info | html %]" /> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19791
:
98922
|
98967
|
99220