From e57d7e184c672ec8d5c19e4d8c563fd11aaab7c2 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 10 Feb 2020 17:58:04 +0000 Subject: [PATCH] Bug 23947: Phase out jquery.cookie.js: MARC Frameworks This patch removes the use of the jquery.cookie plugin on the MARC Frameworks page and replaces it with a call to the new js-cookie library. To test, apply the patch and go to Administration -> MARC bibliographic frameworks. - Choose the 'MARC structure' menu item for one of the frameworks listed. - On the page which lists the tags in the framework, check the box labeled "Display only used tags/subfields." The page should reload. - The checkbox should remain checked and the list of tags should now show only used tags. - Uncheck the checkbox and the page should reload again. You can also follow the changes to the cookie using the browser's developer console. Look for a cookie named 'marctagstructure_selectdisplay' and confirm that the value flips from 0 to 1 and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies https://bugs.koha-community.org/show_bug.cgi?id=24619 Signed-off-by: David Nind Signed-off-by: Katrin Fischer --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt index 3bfc6cded1..eda4824ade 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt @@ -242,7 +242,6 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'datatables.inc' %] [% Asset.js("js/admin-menu.js") | $raw %] - [% Asset.js("lib/jquery/plugins/jquery.cookie.min.js") | $raw %]