From cb2aee92e3d8d7b8da89a5d0704c952f8512d7dd Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 12 Feb 2020 15:49:17 +0100
Subject: [PATCH] Bug 24549: Do not set "last patron" cookie if showLastPatron
is disabled
If the showLastPatron syspref is disabled, we should not store the 3
cookies we use for this feature.
Test plan:
0/ Do not apply this patch
1/ Turn off showLastPatron
2/ Search for a patron, click on a result
3/ Open the cookie list of your browser
=> You see 3 cookies named lastborrowercard, lastborrowername,
lastborrowernumber
4/ Remove them
5/ Apply the patch
6/ Reload the patron detail page
=> The 3 cookies are not created
7/ Turn the pref on
8/ Reload the patron detail page
=> The 3 cookies are created
9/ Eat one of them.
QA note: it's a bit dirty, we should do that JS side, but
staff-global.js is too widely used to make the change easy. Any other
suggestions welcomed.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
---
koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
index a8328bca4ad..95ace5e2485 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
@@ -3,9 +3,11 @@
[% IF ( patron.borrowernumber ) %]
<div class="patroninfo"><h5>[% INCLUDE 'patron-title.inc' %]</h5>
-<input type="hidden" id="hiddenborrowernumber" value="[% patron.borrowernumber | html %]">
-<input type="hidden" id="hiddenborrowername" value="[% patron.surname | html %] [% patron.firstname | html %]">
-<input type="hidden" id="hiddenborrowercard" value="[% patron.cardnumber | html %]">
+[% IF Koha.Preference('showLastPatron') %]
+ <input type="hidden" id="hiddenborrowernumber" value="[% patron.borrowernumber | html %]">
+ <input type="hidden" id="hiddenborrowername" value="[% patron.surname | html %] [% patron.firstname | html %]">
+ <input type="hidden" id="hiddenborrowercard" value="[% patron.cardnumber | html %]">
+[% END %]
[% IF ( patronimages ) %]
<div>
--
2.11.0