From d9df9ed9828b264ee4001fe9bb63f0e7cad68711 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 15 Mar 2019 19:38:29 -0300 Subject: [PATCH] Bug 20728: Remove the 2 GetLastOrder* subroutines Signed-off-by: Martin Renvoize --- C4/Acquisition.pm | 52 ----------------------------------------------- 1 file changed, 52 deletions(-) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index 1d63448131..1bf5b675bb 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -70,7 +70,6 @@ BEGIN { &SearchOrders &GetHistory &GetRecentAcqui &ModReceiveOrder &CancelReceipt &TransferOrder - &GetLastOrderNotReceivedFromSubscriptionid &GetLastOrderReceivedFromSubscriptionid &ModItemOrder &GetParcels @@ -1247,57 +1246,6 @@ sub GetOrder { return $result_set->[0]; } -=head3 GetLastOrderNotReceivedFromSubscriptionid - - $order = &GetLastOrderNotReceivedFromSubscriptionid($subscriptionid); - -Returns a reference-to-hash describing the last order not received for a subscription. - -=cut - -sub GetLastOrderNotReceivedFromSubscriptionid { - my ( $subscriptionid ) = @_; - my $dbh = C4::Context->dbh; - my $query = qq| - SELECT * FROM aqorders - LEFT JOIN subscription - ON ( aqorders.subscriptionid = subscription.subscriptionid ) - WHERE aqorders.subscriptionid = ? - AND aqorders.datereceived IS NULL - LIMIT 1 - |; - my $result_set = - $dbh->selectall_arrayref( $query, { Slice => {} }, $subscriptionid ); - - # result_set assumed to contain 1 match - return $result_set->[0]; -} - -=head3 GetLastOrderReceivedFromSubscriptionid - - $order = &GetLastOrderReceivedFromSubscriptionid($subscriptionid); - -Returns a reference-to-hash describing the last order received for a subscription. - -=cut - -sub GetLastOrderReceivedFromSubscriptionid { - my ( $subscriptionid ) = @_; - my $lastOrderReceived = Koha::Acquisition::Orders->search( - { - subscriptionid => $subscriptionid, - datereceived => { '!=' => undef } - }, - { - order_by => - [ { -desc => 'datereceived' }, { -desc => 'ordernumber' } ] - } - ); - return $lastOrderReceived->count ? $lastOrderReceived->next->unblessed : undef; -} - -#------------------------------------------------------------# - =head3 ModOrder &ModOrder(\%hashref); -- 2.20.1