From 74106f7dc515e1f22164375d306525b598d7f464 Mon Sep 17 00:00:00 2001 From: Didier GAutheron <didier.gautheron@biblibre.com> Date: Thu, 27 Feb 2020 10:51:19 +0100 Subject: [PATCH] BUG 24740: Use biblio title rather than biblio number in OPAC search result cover images tooltips In OPAC biblionum doesn't mean much to patrons, use biblio title field if not empty. Test plan: OPAC search 1) Apply the patch 2) For each cover images providers available to tester in: /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=Cover OPACLocalCoverImages, AdlibrisEnabled, OPACAmazonCoverImages, GoogleJackets, Coce provider. 3) Enable the provider. 4) Search a Library Catalog for a book with a cover image. 6) test mouse over cover image display biblio title. OPAC Shelves 1) Enable OPAC virtualshelves preference 2) Create a list. 3) For each covers providers available. 4) Search the List 5) test mouse over cover image display biblio title. --- .../bootstrap/en/modules/opac-results.tt | 19 ++++++++++++------- .../bootstrap/en/modules/opac-shelves.tt | 18 ++++++++++++------ 2 files changed, 24 insertions(+), 13 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt index a9bf80502e..83603570b3 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt @@ -250,19 +250,24 @@ <td class="bibliocol"> <div class="coverimages itemtype_[% SEARCH_RESULT.itemtype | html %]"> <a class="p1" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber | uri %]"> + [% IF ( SEARCH_RESULT.title ) %] + [% img_title = SEARCH_RESULT.title | html %] + [% ELSE %] + [% img_title = SEARCH_RESULT.biblionumber |url %] + [% END %] [% IF ( OPACLocalCoverImages ) %] - <span title="[% SEARCH_RESULT.biblionumber |url %]" class="[% SEARCH_RESULT.biblionumber | html %]" id="local-thumbnail[% loop.count | html %]"></span> + <span title="[% img_title %]" class="[% SEARCH_RESULT.biblionumber | html %]" id="local-thumbnail[% loop.count | html %]"></span> [% END %] [% IF ( AdlibrisEnabled && SEARCH_RESULT.normalized_isbn ) %] - <span title="[% SEARCH_RESULT.biblionumber | html %]" id="adlibris-thumbnail[% loop.count | html %]"> + <span title="[% img_title %]" id="adlibris-thumbnail[% loop.count | html %]"> <img src="[% AdlibrisURL | html %]?isbn=[% SEARCH_RESULT.normalized_isbn | html %]" alt="Adlibris thumbnail for ISBN: [% SEARCH_RESULT.normalized_isbn | html %]" class="adlibris-cover" /> </span> [% END %] [% IF ( OPACAmazonCoverImages ) %] [% IF ( SEARCH_RESULT.normalized_isbn ) %] - <span title="[% SEARCH_RESULT.biblionumber | html %]" id="amazon-thumbnail[% loop.count | html %]"><img src="https://images-na.ssl-images-amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn | html %].01.TZZZZZZZ.jpg" alt="" class="item-thumbnail" /></span> + <span title="[% img_title %]" id="amazon-thumbnail[% loop.count | html %]"><img src="https://images-na.ssl-images-amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn | html %].01.TZZZZZZZ.jpg" alt="" class="item-thumbnail" /></span> [% ELSE %] <span class="no-image">No cover image available</span> [% END %] @@ -270,7 +275,7 @@ [% IF ( SyndeticsEnabled && SyndeticsCoverImages ) %] [% IF ( SEARCH_RESULT.normalized_isbn || SEARCH_RESULT.normalized_upc || SEARCH_RESULT.normalized_oclc ) %] - <span title="[% SEARCH_RESULT.biblionumber | html %]" id="syndetics-thumbnail[% loop.count | html %]"><img src="https://secure.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn | html %]/SC.GIF&client=[% SyndeticsClientCode | html %]&type=xw10&upc=[% SEARCH_RESULT.normalized_upc | html %]&oclc=[% SEARCH_RESULT.normalized_oclc | html %]" alt="" class="item-thumbnail" /></span> + <span title="[% img_title %]" id="syndetics-thumbnail[% loop.count | html %]"><img src="https://secure.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn | html %]/SC.GIF&client=[% SyndeticsClientCode | html %]&type=xw10&upc=[% SEARCH_RESULT.normalized_upc | html %]&oclc=[% SEARCH_RESULT.normalized_oclc | html %]" alt="" class="item-thumbnail" /></span> [% ELSE %] <span class="no-image">No cover image available</span> [% END %] @@ -278,7 +283,7 @@ [% IF ( GoogleJackets ) %] [% IF ( SEARCH_RESULT.normalized_isbn ) %] - <span title="[% SEARCH_RESULT.biblionumber |url %]" class="[% SEARCH_RESULT.normalized_isbn | html %]" id="gbs-thumbnail[% loop.count | html %]"></span> + <span title="[% img_title %]" class="[% SEARCH_RESULT.normalized_isbn | html %]" id="gbs-thumbnail[% loop.count | html %]"></span> [% ELSE %] <span class="no-image">No cover image available</span> [% END %] @@ -287,7 +292,7 @@ [% IF ( Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) %] [% coce_id = SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn | html %] [% IF ( coce_id ) %] - <span title="[% SEARCH_RESULT.biblionumber |url %]" class="[% coce_id | html %]" id="coce-thumbnail[% loop.count | html %]"></span> + <span title="[% img_title %]" class="[% coce_id | html %]" id="coce-thumbnail[% loop.count | html %]"></span> [% ELSE %] <span class="no-image">No cover image available</span> [% END %] @@ -295,7 +300,7 @@ [% IF OpenLibraryCovers %] [% IF SEARCH_RESULT.normalized_isbn %] - <span title="[% SEARCH_RESULT.biblionumber | html %]" class="[% SEARCH_RESULT.normalized_isbn | html %]" id="openlibrary-thumbnail[% loop.count | html %]"></span> + <span title="[% img_title %]" class="[% SEARCH_RESULT.normalized_isbn | html %]" id="openlibrary-thumbnail[% loop.count | html %]"></span> [% ELSE %] <span class="no-image">No cover image available</span> [% END %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt index dd99fa2788..faee8c658d 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt @@ -323,27 +323,33 @@ <td> <div class="coverimages"> <a class="p1" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% itemsloo.biblionumber | html %]"> + [% IF ( itemsloo.title ) %] + [% img_title = itemsloo.title | html %] + [% ELSE %] + [% img_title = itemsloo.biblionumber |url %] + [% END %] + [% IF ( OPACLocalCoverImages ) %] - <span title="[% itemsloo.biblionumber |url %]" class="[% itemsloo.biblionumber | html %]" id="local-thumbnail[% loop.count | html %]"></span> + <span title="[% img_title %]" class="[% itemsloo.biblionumber | html %]" id="local-thumbnail[% loop.count | html %]"></span> [% END %] [% IF ( AdlibrisEnabled && itemsloo.normalized_isbn ) %] <img src="[% AdlibrisURL | html %]?isbn=[% itemsloo.normalized_isbn | html %]" class="adlibris-cover" alt="Adlibris cover image" /> [% END %] [% IF ( OPACAmazonCoverImages ) %] [% IF ( itemsloo.normalized_isbn ) %] - <span title="[% itemsloo.biblionumber | html %]" id="amazon-thumbnail[% loop.count | html %]"><img src="https://images-na.ssl-images-amazon.com/images/P/[% itemsloo.normalized_isbn | html %].01.TZZZZZZZ.jpg" alt="" /></span> + <span title="[% img_title %]" id="amazon-thumbnail[% loop.count | html %]"><img src="https://images-na.ssl-images-amazon.com/images/P/[% itemsloo.normalized_isbn | html %].01.TZZZZZZZ.jpg" alt="" /></span> [% ELSE %] <span class="no-image">No cover image available</span> [% END %] [% END %] [% IF ( SyndeticsEnabled && SyndeticsCoverImages ) %] - <span title="[% itemsloo.biblionumber | html %]" id="syndetics-thumbnail[% loop.count | html %]"><img src="https://secure.syndetics.com/index.aspx?isbn=[% itemsloo.normalized_isbn | html %]/SC.GIF&client=[% SyndeticsClientCode | html %]&type=xw10&upc=[% itemsloo.normalized_upc | html %]&oclc=[% itemsloo.normalized_oclc | html %]" alt="" /></span> + <span title="[% img_title %]" id="syndetics-thumbnail[% loop.count | html %]"><img src="https://secure.syndetics.com/index.aspx?isbn=[% itemsloo.normalized_isbn | html %]/SC.GIF&client=[% SyndeticsClientCode | html %]&type=xw10&upc=[% itemsloo.normalized_upc | html %]&oclc=[% itemsloo.normalized_oclc | html %]" alt="" /></span> [% END %] [% IF ( GoogleJackets ) %] [% IF ( itemsloo.normalized_isbn ) %] - <div title="[% itemsloo.biblionumber |url %]" class="[% itemsloo.normalized_isbn | html %]" id="gbs-thumbnail[% loop.count | html %]"></div> + <div title="[% img_title %]" class="[% itemsloo.normalized_isbn | html %]" id="gbs-thumbnail[% loop.count | html %]"></div> [% ELSE %] <span class="no-image">No cover image available</span> [% END %] @@ -352,7 +358,7 @@ [% IF ( Koha.Preference('Coce') && Koha.Preference('CoceProviders') ) %] [% coce_id = itemsloo.normalized_ean || itemsloo.normalized_isbn %] [% IF ( coce_id ) %] - <span title="[% itemsloo.biblionumber |url %]" class="[% coce_id | html %]" id="coce-thumbnail[% loop.count | html %]"></span> + <span title="[% img_title %]" class="[% coce_id | html %]" id="coce-thumbnail[% loop.count | html %]"></span> [% ELSE %] <span class="no-image">No cover image available</span> [% END %] @@ -361,7 +367,7 @@ [% IF OpenLibraryCovers %] [% IF itemsloo.normalized_isbn %] - <span title="[% itemsloo.biblionumber | html %]" class="[% itemsloo.normalized_isbn | html %]" id="openlibrary-thumbnail[% loop.count | html %]"></span> + <span title="[% img_title %]" class="[% itemsloo.normalized_isbn | html %]" id="openlibrary-thumbnail[% loop.count | html %]"></span> [% ELSE %] <span class="no-image">No cover image available</span> [% END %] -- 2.17.1