Bugzilla – Attachment 99729 Details for
Bug 24739
Buster ships with Net::Netmask 1.9104 which supports IPv6
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24739: Skip tests when IPv6 support is found
Bug-24739-Skip-tests-when-IPv6-support-is-found.patch (text/plain), 2.09 KB, created by
David Cook
on 2020-02-28 00:21:13 UTC
(
hide
)
Description:
Bug 24739: Skip tests when IPv6 support is found
Filename:
MIME Type:
Creator:
David Cook
Created:
2020-02-28 00:21:13 UTC
Size:
2.09 KB
patch
obsolete
>From 3779f13d01e18e2112a206bc0adf81ac3b0418fd Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 27 Feb 2020 09:16:12 +0000 >Subject: [PATCH] Bug 24739: Skip tests when IPv6 support is found > >Signed-off-by: David Cook <dcook@prosentient.com.au> >--- > t/Koha/Middlware/RealIP.t | 26 +++++++++++++++++++------- > 1 file changed, 19 insertions(+), 7 deletions(-) > >diff --git a/t/Koha/Middlware/RealIP.t b/t/Koha/Middlware/RealIP.t >index a32577a876..28a45428e6 100644 >--- a/t/Koha/Middlware/RealIP.t >+++ b/t/Koha/Middlware/RealIP.t >@@ -85,10 +85,22 @@ t::lib::Mocks::mock_config('koha_trusted_proxies', '1.1.1.0:255.255.255.0'); > $address = Koha::Middleware::RealIP::get_real_ip( $remote_address, $x_forwarded_for_header ); > is($address,'2.2.2.2',"Trust proxy (1.1.1.1) using an IP address and netmask separated by a colon, so use the X-Forwarded-For header for the remote address"); > >-$remote_address = "2001:db8:1234:5678:abcd:1234:abcd:1234"; >-$x_forwarded_for_header = "2.2.2.2"; >-t::lib::Mocks::mock_config('koha_trusted_proxies', '2001:db8:1234:5678::/64'); >-warning_is { >- $address = Koha::Middleware::RealIP::get_real_ip( $remote_address, $x_forwarded_for_header ); >-} "could not parse 2001:db8:1234:5678::/64","Warn on IPv6 koha_trusted_proxies"; >-is($address,'2001:db8:1234:5678:abcd:1234:abcd:1234',"IPv6 support was added in 1.9104 version of Net::Netmask"); >+require Net::Netmask; >+SKIP: { >+ skip "Net::Netmask at 1.9104+ supports IPv6", 2 unless Net::Netmask->VERSION < 1.9104; >+ >+ $remote_address = "2001:db8:1234:5678:abcd:1234:abcd:1234"; >+ $x_forwarded_for_header = "2.2.2.2"; >+ t::lib::Mocks::mock_config( 'koha_trusted_proxies', '2001:db8:1234:5678::/64' ); >+ warning_is { >+ $address = Koha::Middleware::RealIP::get_real_ip( $remote_address, >+ $x_forwarded_for_header ); >+ } >+ "could not parse 2001:db8:1234:5678::/64", >+ "Warn on IPv6 koha_trusted_proxies"; >+ is( >+ $address, >+ '2001:db8:1234:5678:abcd:1234:abcd:1234', >+ "IPv6 support was added in 1.9104 version of Net::Netmask" >+ ); >+} >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24739
:
99690
|
99729
|
99730
|
99748
|
99749
|
99750
|
99751
|
99752