View | Details | Raw Unified | Return to bug 24759
Collapse All | Expand All

(-)a/t/db_dependent/Circulation/issue.t (-22 / +63 lines)
Lines 23-32 use DateTime::Duration; Link Here
23
use t::lib::Mocks;
23
use t::lib::Mocks;
24
use t::lib::TestBuilder;
24
use t::lib::TestBuilder;
25
25
26
use C4::Circulation;
27
use C4::Items;
28
use C4::Biblio;
26
use C4::Biblio;
27
use C4::Circulation;
29
use C4::Context;
28
use C4::Context;
29
use C4::Items;
30
use C4::Reserves;
30
use C4::Reserves;
31
use Koha::Checkouts;
31
use Koha::Checkouts;
32
use Koha::Database;
32
use Koha::Database;
Lines 243-267 like( Link Here
243
my $stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef, $borrower_id1, $item_id1, $branchcode_3 );
243
my $stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef, $borrower_id1, $item_id1, $branchcode_3 );
244
ok( $stat, "Bug 17781 - 'Improper branchcode set during renewal' still fixed" );
244
ok( $stat, "Bug 17781 - 'Improper branchcode set during renewal' still fixed" );
245
245
246
$se->mock( 'interface', sub {return 'opac'});
246
subtest 'Show that AddRenewal respects OpacRenewalBranch and interface' => sub {
247
247
    plan tests => 5;
248
#Let's do an opac renewal - whatever branchcode we send should be used
248
249
my $opac_renew_issue = $builder->build({
249
    $se->mock( 'interface', sub { return 'opac' } );
250
    source=>"Issue",
250
251
    value=>{
251
    t::lib::Mocks::mock_preference( 'OpacRenewalBranch', 'opacrenew' );
252
        date_due => '2017-01-01',
252
    my $item = $builder->build_sample_item({ itype => $itemtype});
253
        branch => $branchcode_1,
253
    my $opac_renew_issue = C4::Circulation::AddIssue( $borrower_1, $item->barcode );
254
        itype => $itemtype,
254
    AddRenewal(
255
        borrowernumber => $borrower_id1
255
        $borrower_id1,
256
    }
256
        $item->itemnumber,
257
});
257
        "Stavromula", $datedue1, $daysago10
258
258
    );
259
my $datedue4 = AddRenewal( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber}, "Stavromula", $datedue1, $daysago10 );
259
    my $stat = $schema->resultset('Statistic')->search({ itemnumber => $item->itemnumber, type => 'renew' })->next;
260
260
    is( $stat->branch, "OPACRenew", "OpacRenewalBranch is respected for OpacRenewalBranch = OPACRenew" );
261
$stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef,  $opac_renew_issue->{borrowernumber},  $opac_renew_issue->{itemnumber}, "Stavromula" );
261
262
ok( $stat, "Bug 18572 - 'Bug 18572 - OpacRenewalBranch is now respected" );
262
    t::lib::Mocks::mock_preference( 'OpacRenewalBranch', 'checkoutbranch' );
263
263
    my $item2 = $builder->build_sample_item({ itype => $itemtype});
264
264
    $opac_renew_issue = C4::Circulation::AddIssue( $borrower_1, $item2->barcode );
265
    AddRenewal(
266
        $borrower_id1,
267
        $item2->itemnumber,
268
        "Stavromula", $datedue1, $daysago10
269
    );
270
    $stat = $schema->resultset('Statistic')->search({ itemnumber => $item2->itemnumber, type => 'renew' })->next;
271
    is( $stat->branch, $patron_1->branchcode, "OpacRenewalBranch is respected for OpacRenewalBranch = checkoutbranch" );
272
273
    t::lib::Mocks::mock_preference( 'OpacRenewalBranch', 'patronhomebranch' );
274
    my $item3 = $builder->build_sample_item({ itype => $itemtype});
275
    $opac_renew_issue = C4::Circulation::AddIssue( $borrower_1, $item3->barcode );
276
    AddRenewal(
277
        $borrower_id1,
278
        $item3->itemnumber,
279
        "Stavromula", $datedue1, $daysago10
280
    );
281
    $stat = $schema->resultset('Statistic')->search({ itemnumber => $item3->itemnumber, type => 'renew' })->next;
282
    my $patron = Koha::Patrons->find( $borrower_id1 );
283
    is( $stat->branch, $patron->branchcode, "OpacRenewalBranch is respected for OpacRenewalBranch = patronhomebranch" );
284
285
    t::lib::Mocks::mock_preference( 'OpacRenewalBranch', 'itemhomebranch' );
286
    my $item4 = $builder->build_sample_item({ itype => $itemtype});
287
    $opac_renew_issue = C4::Circulation::AddIssue( $borrower_1, $item4->barcode );
288
    AddRenewal(
289
        $borrower_id1,
290
        $item4->itemnumber,
291
        "Stavromula", $datedue1, $daysago10
292
    );
293
    $stat = $schema->resultset('Statistic')->search({ itemnumber => $item4->itemnumber, type => 'renew' })->next;
294
    is( $stat->branch, $item4->homebranch, "OpacRenewalBranch is respected for OpacRenewalBranch = itemhomebranch" );
295
296
    t::lib::Mocks::mock_preference( 'OpacRenewalBranch', 'none' );
297
    my $item5 = $builder->build_sample_item({ itype => $itemtype});
298
    $opac_renew_issue = C4::Circulation::AddIssue( $borrower_1, $item5->barcode );
299
    AddRenewal(
300
        $borrower_id1,
301
        $item5->itemnumber,
302
        "Stavromula", $datedue1, $daysago10
303
    );
304
    $stat = $schema->resultset('Statistic')->search({ itemnumber => $item5->itemnumber, type => 'renew' })->next;
305
    is( $stat->branch, "", "OpacRenewalBranch is respected for OpacRenewalBranch none" );
306
};
265
307
266
#Test GetBiblioIssues
308
#Test GetBiblioIssues
267
is( GetBiblioIssues(), undef, "GetBiblio Issues without parameters" );
309
is( GetBiblioIssues(), undef, "GetBiblio Issues without parameters" );
268
- 

Return to bug 24759