From c89871778f4396a909dfbaa7a319d93a4a358e30 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Sat, 29 Feb 2020 17:10:45 -0300 Subject: [PATCH] Bug 15985: Add more tests Signed-off-by: Tomas Cohen Arazi --- t/db_dependent/Koha/Account/Lines.t | 80 ++++++++++++++++++++--------- t/db_dependent/Koha/Checkout.t | 50 ++++++++++++++++++ 2 files changed, 105 insertions(+), 25 deletions(-) create mode 100644 t/db_dependent/Koha/Checkout.t diff --git a/t/db_dependent/Koha/Account/Lines.t b/t/db_dependent/Koha/Account/Lines.t index 2b881df1c5..d7ba28fee3 100755 --- a/t/db_dependent/Koha/Account/Lines.t +++ b/t/db_dependent/Koha/Account/Lines.t @@ -1209,46 +1209,76 @@ subtest "reduce() tests" => sub { }; subtest 'checkout' => sub { - plan tests => 1; + plan tests => 5; $schema->storage->txn_begin; - my $library = $builder->build( { source => 'Branch' } ); - my $biblioitem = $builder->build( { source => 'Biblioitem' } ); - my $patron = $builder->build( { source => 'Borrower' } ); - my $item = Koha::Item->new( - { - biblionumber => $biblioitem->{biblionumber}, - biblioitemnumber => $biblioitem->{biblioitemnumber}, - homebranch => $library->{branchcode}, - holdingbranch => $library->{branchcode}, - barcode => 'some_barcode_13', - itype => 'BK', - } - )->store; + my $library = $builder->build_object({ class => 'Koha::Libraries' } ); + my $patron = $builder->build_object({ class => 'Koha::Patrons' } ); + my $item_1 = $builder->build_sample_item({ library => $library->branchcode }); my $checkout = Koha::Checkout->new( { - borrowernumber => $patron->{borrowernumber}, - itemnumber => $item->itemnumber, - branchcode => $library->{branchcode}, + borrowernumber => $patron->borrowernumber, + itemnumber => $item_1->itemnumber, + branchcode => $library->branchcode, } )->store; - my $line = Koha::Account::Line->new( + my $line = $builder->build_object( { - borrowernumber => $patron->{borrowernumber}, - itemnumber => $item->itemnumber, - issue_id => $checkout->id, - accounttype => "F", - amount => 10, - interface => 'commandline', + class => 'Koha::Account::Lines', + value => { + borrowernumber => $patron->borrowernumber, + itemnumber => $item_1->itemnumber, + issue_id => $checkout->id, + } } - )->store; + ); + is( ref($line->checkout), 'Koha::Checkout', 'Object type is correct' ); is( $line->checkout->id, $checkout->id, 'Koha::Account::Line->checkout should return the correct checkout' ); + my $item_2 = $builder->build_sample_item({ library => $library->branchcode }); + my $old_checkout = $builder->build_object( + { + class => 'Koha::Old::Checkouts', + value => { + borrowernumber => $patron->borrowernumber, + itemnumber => $item_2->itemnumber, + branchcode => $library->branchcode + } + } + ); + + my $old_checkout_line = $builder->build_object( + { + class => 'Koha::Account::Lines', + value => { + borrowernumber => $patron->borrowernumber, + itemnumber => $item_2->itemnumber, + issue_id => $old_checkout->id, + } + } + ); + + is( ref($old_checkout_line->checkout), 'Koha::Old::Checkout', 'Object type is correct' ); + is( $old_checkout_line->checkout->id, $old_checkout->id, + 'Koha::Account::Line->checkout should return the correct (old) checkout' ); + + my $no_checkout_line = $builder->build_object( + { + class => 'Koha::Account::Lines', + value => { + itemnumber => $item_2->itemnumber, + issue_id => undef + } + } + ); + + is( $no_checkout_line->checkout, undef, 'No issue_id makes it return undef' ); + $schema->storage->txn_rollback; }; diff --git a/t/db_dependent/Koha/Checkout.t b/t/db_dependent/Koha/Checkout.t new file mode 100644 index 0000000000..1c433a4c60 --- /dev/null +++ b/t/db_dependent/Koha/Checkout.t @@ -0,0 +1,50 @@ +#!/usr/bin/perl + +# Copyright 2020 Koha Development team +# +# This file is part of Koha +# +# Koha is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# Koha is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with Koha; if not, see . + +use Modern::Perl; + +use Test::More tests => 1; +use t::lib::TestBuilder; + +use Koha::Database; + +my $builder = t::lib::TestBuilder->new; +my $schema = Koha::Database->new->schema; + +subtest 'library() tests' => sub { + + plan tests => 2; + + $schema->storage->txn_begin; + + my $library = $builder->build_object({ class => 'Koha::Libraries' }); + my $checkout = $builder->build_object( + { + class => 'Koha::Checkouts', + value => { + branchcode => $library->branchcode + } + } + ); + + is( ref($checkout->library), 'Koha::Library', 'Object type is correct' ); + is( $checkout->library->branchcode, $library->branchcode, 'Right library linked' ); + + $schema->storage->txn_rollback; +}; -- 2.25.0