From 5d6a82a6858773c265e071ac84102ab4277781cd Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Wed, 17 Oct 2018 19:56:12 +0000
Subject: [PATCH] Bug 21591: Check for record level item type issues too

To test:
1 - sudo koha-mysql kohadev
2 - UPDATE biblioitems SET itemtype = NULL where biblionumber = 1
3 - UPDATE items SET itype = NULL where biblionumber = 1
4 - perl misc/maintenance/search_for_data_inconsistencies.pl
5 - Notice warnings
6 - Apply patch
7 - Undefined itemtype on bibliolevel is now warned
7 - Test also with itype=""
---
 misc/maintenance/search_for_data_inconsistencies.pl | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/misc/maintenance/search_for_data_inconsistencies.pl b/misc/maintenance/search_for_data_inconsistencies.pl
index 1790495e88..0ee8d25344 100755
--- a/misc/maintenance/search_for_data_inconsistencies.pl
+++ b/misc/maintenance/search_for_data_inconsistencies.pl
@@ -54,14 +54,21 @@ use Koha::ItemTypes;
 
 {
     if ( C4::Context->preference('item-level_itypes') ) {
-        my $items_without_itype = Koha::Items->search( { itype => undef } );
+        my $items_without_itype = Koha::Items->search( { -or => [itype => undef,itype => ''] } );
         if ( $items_without_itype->count ) {
             new_section("Items do not have itype defined");
             while ( my $item = $items_without_itype->next ) {
-                new_item(
-                    sprintf "Item with itemnumber=%s does not have a itype value, biblio's item type will be used (%s)",
-                    $item->itemnumber, $item->biblioitem->itemtype
-                );
+                if (defined $item->biblioitem->itemtype && $item->biblioitem->itemtype ne '' ) {
+                    new_item(
+                        sprintf "Item with itemnumber=%s does not have a itype value, biblio's item type will be used (%s)",
+                        $item->itemnumber, $item->biblioitem->itemtype
+                    );
+                } else {
+                    new_item(
+                        sprintf "Item with itemnumber=%s does not have a itype value, additionally no item type defined for biblionumber=%s",
+                        $item->itemnumber, $item->biblioitem->biblionumber
+                    );
+               }
             }
             new_hint("The system preference item-level_itypes expects item types to be defined at item level");
         }
@@ -82,7 +89,7 @@ use Koha::ItemTypes;
 
     my @itemtypes = Koha::ItemTypes->search->get_column('itemtype');
     if ( C4::Context->preference('item-level_itypes') ) {
-        my $items_with_invalid_itype = Koha::Items->search( { itype => { not_in => \@itemtypes } } );
+        my $items_with_invalid_itype = Koha::Items->search( { -and => [itype => { not_in => \@itemtypes }, itype => { '!=' => '' }] } );
         if ( $items_with_invalid_itype->count ) {
             new_section("Items have invalid itype defined");
             while ( my $item = $items_with_invalid_itype->next ) {
-- 
2.11.0