Back to bug 31963
Who | When | What | Removed | Added |
---|---|---|---|---|
aleisha | 2022-10-24 21:42:14 UTC | Assignee | koha-bugs | aleisha |
Change sponsored? | --- | Sponsored | ||
aleisha | 2022-10-24 21:42:52 UTC | Version | 22.05 | master |
aleisha | 2022-10-24 23:22:51 UTC | Status | NEW | Needs Signoff |
Patch complexity | --- | Small patch | ||
aleisha | 2022-10-24 23:23:29 UTC | Text to go in the release notes | This patch ensures HoldFeeMode is considered when displaying a message to patrons on the OPAC that says they'll be charged a hold fee when placing or collecting the hold. When HoldFeeMode is set to not_always or "only if all items are checked out and the record has at least one hold already" then the hold fee message should only show if all items on the record are checked out, AND the record has at least one hold already - both of these conditions must be met. |
|
david | 2022-10-25 01:38:22 UTC | Status | Needs Signoff | Signed Off |
david | 2022-10-25 01:38:27 UTC | Attachment #142585 Attachment is obsolete | 0 | 1 |
katrin.fischer | 2022-11-02 13:43:05 UTC | Summary | Only show reserve fee message on OPAC if they will actually be charged | Only show hold fee message on OPAC if they will actually be charged |
katrin.fischer | 2022-11-02 13:43:35 UTC | QA Contact | testopia | katrin.fischer |
katrin.fischer | 2022-11-02 14:23:52 UTC | Status | Signed Off | Passed QA |
katrin.fischer | 2022-11-02 14:23:56 UTC | Attachment #142592 Attachment is obsolete | 0 | 1 |
katrin.fischer | 2022-11-02 14:24:38 UTC | Keywords | release-notes-needed | |
aleisha | 2022-11-03 01:17:29 UTC | Text to go in the release notes | the record has at least one hold already" then the hold fee message should only show if all items on the record are checked out, AND the record has at least one hold already - both of these conditions must be met. | , Koha will unexpectedly show a hold fee message and charge a hold fee if at least one of those conditions are met. This patch fixes the behaviour so that a hold fee message is only shown, and hold fee only charged |
Summary | Only show hold fee message on OPAC if they will actually be charged | Only show hold fee message on OPAC and charge hold fee is HoldFeeMode conditions are true as described in the system preference | ||
Text to go in the release notes | This patch ensures HoldFeeMode is considered when displaying a message to patrons on the OPAC that says they'll be charged a hold fee when placing or collecting the hold. When HoldFeeMode is set to not_always or "only if all items are checked out and | , if all items on the record are checked out, AND the record has at least one hold already - both of these conditions must be met, as the system preference implies. When HoldFeeMode is set to not_always or "only if all items are checked out and the record has at least one hold already" | ||
aleisha | 2022-11-03 01:18:02 UTC | Summary | Only show hold fee message on OPAC and charge hold fee is HoldFeeMode conditions are true as described in the system preference | Only show hold fee message on OPAC and charge hold fee if HoldFeeMode conditions are true as described in the system preference |
tomascohen | 2022-11-03 12:05:42 UTC | Version(s) released in | 22.11.00 | |
Status | Passed QA | Pushed to master | ||
aleisha | 2022-11-09 00:54:58 UTC | Blocks | 32142 | |
lucas | 2023-01-17 15:26:40 UTC | CC | lucas | |
Status | Pushed to master | Needs documenting | ||
caroline.cyr-la-rose | 2023-05-05 19:31:06 UTC | Status | Needs documenting | RESOLVED |
CC | caroline.cyr-la-rose | |||
Resolution | --- | FIXED | ||
lucas | 2023-05-15 21:37:15 UTC | Blocks | 33210 | |
katrin.fischer | 2023-12-28 20:42:58 UTC | Status | RESOLVED | CLOSED |
lisette | 2024-11-07 16:08:48 UTC | Keywords | release-notes-needed |
Back to bug 31963