Bug 19998

Summary: use Modern::Perl in error perl scripts
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: Architecture, internals, and plumbingAssignee: Te Rauhina Jackson <terauhina.jackson>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer, nick
Version: unspecifiedKeywords: Academy
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Change sponsored?: --- Patch complexity: Trivial patch
Bot Control: --- When did the bot last check this:
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 2505    
Attachments: Bug 19998 - use Modern::Perl in error perl scripts
Bug 19998 - use Modern::Perl in error perl scripts
Bug 19998 - use Modern::Perl in error perl scripts
Bug 19998: use Modern::Perl in error perl scripts

Description Aleisha Amohia 2018-01-17 04:44:31 UTC
use Modern::Perl should be used instead of use strict; use warnings;

Relevant in:
400.pl
401.pl
402.pl
403.pl
404.pl
500.pl
Comment 1 Te Rauhina Jackson 2018-01-18 03:18:06 UTC
Created attachment 70670 [details] [review]
Bug 19998 - use Modern::Perl in error perl scripts

Test Plan:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

400.pl
401.pl
402.pl
403.pl
404.pl
500.pl
Comment 2 Jon Knight 2018-01-24 18:19:09 UTC
Created attachment 70886 [details] [review]
Bug 19998 - use Modern::Perl in error perl scripts

Test Plan:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

400.pl
401.pl
402.pl
403.pl
404.pl
500.pl
Comment 3 Jon Knight 2018-01-24 18:36:09 UTC
Created attachment 70893 [details] [review]
Bug 19998 - use Modern::Perl in error perl scripts

Test Plan:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

400.pl
401.pl
402.pl
403.pl
404.pl
500.pl

Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
Comment 4 Katrin Fischer 2018-02-04 14:10:08 UTC
Created attachment 71192 [details] [review]
Bug 19998: use Modern::Perl in error perl scripts

Test Plan:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

400.pl
401.pl
402.pl
403.pl
404.pl
500.pl

Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Jonathan Druart 2018-02-05 12:59:08 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 6 Nick Clemens 2018-02-16 00:58:12 UTC
Awesome work all! Enhancement not backported to stable.