| Summary: | Don't include line breaks in strings that are translated | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 10002 - Don't include line breaks in strings that are translated
Bug 10002 - Don't include line breaks in strings that are translated Bug 10002 - Don't include line breaks in strings that are translated |
||
|
Description
Katrin Fischer
2013-04-08 14:57:45 UTC
Created attachment 17319 [details] [review] Bug 10002 - Don't include line breaks in strings that are translated Several JS alert messages contain "\n" which is problematic for translation. This patch removes those instances (a line break is not strictly necessary anyway). Also corrected: two instances of "holds(s)" To test, place a hold on a title with items. From the biblio detail page choose Edit -> Delete all items and Edit -> Delete record. In each case you should see error messages with no line breaks and no misspellings. Delete all items attached to the record with holds from the item edit page. Go back to the detail page and choose Edit -> Delete record. You should see an error message about existing hold(s) with no line breaks or misspellings. Created attachment 17325 [details] [review] Bug 10002 - Don't include line breaks in strings that are translated Several JS alert messages contain "\n" which is problematic for translation. This patch removes those instances (a line break is not strictly necessary anyway). Also corrected: two instances of "holds(s)" To test, place a hold on a title with items. From the biblio detail page choose Edit -> Delete all items and Edit -> Delete record. In each case you should see error messages with no line breaks and no misspellings. Delete all items attached to the record with holds from the item edit page. Go back to the detail page and choose Edit -> Delete record. You should see an error message about existing hold(s) with no line breaks or misspellings. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Harmless change, fixes misspellings and makes translations easier Created attachment 17340 [details] [review] Bug 10002 - Don't include line breaks in strings that are translated Several JS alert messages contain "\n" which is problematic for translation. This patch removes those instances (a line break is not strictly necessary anyway). Also corrected: two instances of "holds(s)" To test, place a hold on a title with items. From the biblio detail page choose Edit -> Delete all items and Edit -> Delete record. In each case you should see error messages with no line breaks and no misspellings. Delete all items attached to the record with holds from the item edit page. Go back to the detail page and choose Edit -> Delete record. You should see an error message about existing hold(s) with no line breaks or misspellings. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Harmless change, fixes misspellings and makes translations easier Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master and 3.12.x. Pushed to 3.10.x will be in 3.10.6 |