Summary: | inventory checks items in without warning | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, katrin.fischer, liz, marjorie.barry-vila, sophie.meynieux, tmisilo, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12327 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 10005: Inventory - Add an option to not check in items
[SIGNED OFF] Bug 10005: Inventory - Add an option to not check in items [PASSED QA] Bug 10005: Inventory - Add an option to not check in items |
Description
Nicole C. Engard
2013-04-08 20:26:55 UTC
Created attachment 40990 [details] [review] Bug 10005: Inventory - Add an option to not check in items The inventory tools automatically check in items, this patch adds it as an option. Test plan: 1/ Check an item out, fill a file with its barcode, and use this file in the inventory tools. 2/ Check the new checkbox and confirm that the item is not checked in 3/ Repeat again and don't check it, the behavior should be the same as before this patch. *** Bug 12327 has been marked as a duplicate of this bug. *** Comment on attachment 40990 [details] [review] Bug 10005: Inventory - Add an option to not check in items Review of attachment 40990 [details] [review]: ----------------------------------------------------------------- ::: tools/inventory.pl @@ +218,5 @@ > + if ($doreturn){ > + push @errorloop, {'barcode'=>$barcode,'ERR_ONLOAN_RET'=>1} > + } else { > + push @errorloop, {'barcode'=>$barcode,'ERR_ONLOAN_NOT_RET'=>1} > + } This unless statement merely doesn't check them in. Where's the warning as requested in comment #1? (In reply to M. Tompsett from comment #3) > Comment on attachment 40990 [details] [review] [review] > Bug 10005: Inventory - Add an option to not check in items > > Review of attachment 40990 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: tools/inventory.pl > @@ +218,5 @@ > > + if ($doreturn){ > > + push @errorloop, {'barcode'=>$barcode,'ERR_ONLOAN_RET'=>1} > > + } else { > > + push @errorloop, {'barcode'=>$barcode,'ERR_ONLOAN_NOT_RET'=>1} > > + } > > This unless statement merely doesn't check them in. Where's the warning as > requested in comment #1? I don't get it. Did you test the patch? From the description; "I think the problem here is that there is no warning or way to tell Koha to not check the items in" I have chosen the second way and added a checkbox. Created attachment 41435 [details] [review] [SIGNED OFF] Bug 10005: Inventory - Add an option to not check in items The inventory tools automatically check in items, this patch adds it as an option. Test plan: 1/ Check an item out, fill a file with its barcode, and use this file in the inventory tools. 2/ Check the new checkbox and confirm that the item is not checked in 3/ Repeat again and don't check it, the behavior should be the same as before this patch. Signed-off-by: Jason Robb <jrobb@sekls.org> I've added a missing </li>. The patch would be a little nicer, if there was a nice message for 'already on loan' - but this works, as it no longer checks the item in. Created attachment 42443 [details] [review] [PASSED QA] Bug 10005: Inventory - Add an option to not check in items The inventory tools automatically check in items, this patch adds it as an option. Test plan: 1/ Check an item out, fill a file with its barcode, and use this file in the inventory tools. 2/ Check the new checkbox and confirm that the item is not checked in 3/ Repeat again and don't check it, the behavior should be the same as before this patch. Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Added a missing </li>. Patch works as expected. Patch pushed to master. Thanks Jonathan! Pushed to 3.20.x will be in 3.20.4 Could this one be in 3.18 ? Because it could result in severe loss of data. (In reply to Sophie MEYNIEUX from comment #10) > Could this one be in 3.18 ? Because it could result in severe loss of data. Adding Liz to the CC list :) Sorry I didn't check before, but apparently it is in 3.18.11 |