Summary: | degree notation in acq | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, m.de.rooy, mathsabypro |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/acqui/booksellers.pl | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
N notation on acq searches
Bug 10023: Change degree notation for number to No. Bug 10023: Change degree notation for number to # [SIGNED-OFF] Bug 10023: Change degree notation for number to No. Bug 10023: Change degree notation for number to # Bug 10023: Change degree notation for number to No. |
It is a french notation (we never use #, but use N° instead). Maybe this table was made by a french developper... So if N° is strange in english, we should replace it by #. French ppl will translate it as N°. M. Saby I think # could be a bit confusing to translators. I found a discussion about this and # seems also to be more American English: http://forum.wordreference.com/showthread.php?t=264328&page=3 I will propose a patch changing the N° to No. instead. There are some # on other pages. Should we replace them by "No" too? Mathieu Created attachment 17416 [details] [review] Bug 10023: Change degree notation for number to No. This patch changes N<little circle> to No. in three templates. To test: 1) Search for a vendor with visible baskets. Check that the first column of the basket table in the is now labelled No. 2) Print a PDF order in acquisitons with layout2pages. 3) Print a PDF oder in acquisitons with layout3pages. Check both generated PDFs for the correct syntax. Note: you need to switch the system preference OrderPdfFormat in order to test 2) and 3). The 2 possible settings are: pdfformat::layout3pages pdfformat::layout2pages It's not only Koha - git bz doesn't like the degree notation either. Created attachment 17417 [details] [review] Bug 10023: Change degree notation for number to # This patch changes N<little circle> to # in three templates. To test: 1) Search for a vendor with visible baskets. Check that the first column of the basket table in the is now labelled # 2) Print a PDF order in acquisitons with layout2pages. 3) Print a PDF oder in acquisitons with layout3pages. Check both generated PDFs for the correct syntax. Note: you need to switch the system preference OrderPdfFormat in order to test 2) and 3). The 2 possible settings are: pdfformat::layout3pages pdfformat::layout2pages It's not only Koha - git bz doesn't like the degree notation either. Hm, thinking some more about this, I provided the same patch with #. Anyway, degree sign should not be used. the ° is for an supperscript "o", which was hard to type with typewriters. If this page is correct, we should replace it by "No." for non-american english : http://en.wikipedia.org/wiki/Numero_sign Is understandable for american english ? M. saby Created attachment 17459 [details] [review] [SIGNED-OFF] Bug 10023: Change degree notation for number to No. This patch changes N<little circle> to No. in three templates. To test: 1) Search for a vendor with visible baskets. Check that the first column of the basket table in the is now labelled No. 2) Print a PDF order in acquisitons with layout2pages. 3) Print a PDF oder in acquisitons with layout3pages. Check both generated PDFs for the correct syntax. Note: you need to switch the system preference OrderPdfFormat in order to test 2) and 3). The 2 possible settings are: pdfformat::layout3pages pdfformat::layout2pages It's not only Koha - git bz doesn't like the degree notation either. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I prefer "No." over "#" and my survey of the templates shows that "No." appears more often. Looks like something to add to our style guide. Created attachment 17589 [details] [review] Bug 10023: Change degree notation for number to # This patch changes N<little circle> to # in three templates. To test: 1) Search for a vendor with visible baskets. Check that the first column of the basket table in the is now labelled # 2) Print a PDF order in acquisitons with layout2pages. 3) Print a PDF oder in acquisitons with layout3pages. Check both generated PDFs for the correct syntax. Note: you need to switch the system preference OrderPdfFormat in order to test 2) and 3). The 2 possible settings are: pdfformat::layout3pages pdfformat::layout2pages It's not only Koha - git bz doesn't like the degree notation either. Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 17590 [details] [review] Bug 10023: Change degree notation for number to No. This patch changes N<little circle> to No. in three templates. To test: 1) Search for a vendor with visible baskets. Check that the first column of the basket table in the is now labelled No. 2) Print a PDF order in acquisitons with layout2pages. 3) Print a PDF oder in acquisitons with layout3pages. Check both generated PDFs for the correct syntax. Note: you need to switch the system preference OrderPdfFormat in order to test 2) and 3). The 2 possible settings are: pdfformat::layout3pages pdfformat::layout2pages It's not only Koha - git bz doesn't like the degree notation either. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I prefer "No." over "#" and my survey of the templates shows that "No." appears more often. Looks like something to add to our style guide. Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> QA Comment: Looks good to me. More or less a string patch. No problems with koha-qa. Passed QA This patch has been pushed to master and 3.12.x. I also added a follow-up changing the last occurrences. Does not apply to 3.10.x, please send a new patch if it is needed |
Created attachment 17345 [details] N notation on acq searches See the screenshot, above the basket number it now says N° ... this seems like a strange notation to me? Shouldn't it be # if we just want a small notation?