Summary: | When SingleBranchMode is enabled, allow superlibrarians to set logged in library | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall <kyle.m.hall> |
Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall <kyle.m.hall> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library
[SIGNED-OFF] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library [PASSED QA] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library |
Description
Kyle M Hall
2013-04-15 13:08:57 UTC
Created attachment 17453 [details] [review] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library Currently, when SingleBranchMode is enabled, nobody can change the logged in library in Koha. To change it requires disable SingleBranchMode, switching the library, and re-enabling it. It seems reasonable to allow superlibrarians to switch the logged in library even if SingleBranchMode is enabled. Test Plan: 1) Apply this patch 3) Enable SingleBranchMode 4) Log in as a superlibrarian 5) Attempt to change the logged in branch This change should succeed 6) Log in as a non-superlibrarian account 7) Attempt to change the logged n branch This should not be allowed, as per Koha's current behavior Hm, but shouldn't you have only one library when singlebranchmode is enabled? I am asking because we have a bug to remove this system preference altogether: bug 7314 When you log in as the admin user you don't have a branch. As a support company the only user we have is the admin user and when we log in to the system we can't change the branch because of the single branch mode silliness. Hm, we work differently. We have an administration account in each library and only use the database admin account for updating and creating this user. That said - the change looks pretty small, but I was wondering about the use case. :) How do you prevent the libraries from messing with your user? That's why we use the admin one. Nicole We don't - they know it's us and don't change it. :) Created attachment 18049 [details] [review] [SIGNED-OFF] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library Currently, when SingleBranchMode is enabled, nobody can change the logged in library in Koha. To change it requires disable SingleBranchMode, switching the library, and re-enabling it. It seems reasonable to allow superlibrarians to switch the logged in library even if SingleBranchMode is enabled. Test Plan: 1) Apply this patch 3) Enable SingleBranchMode 4) Log in as a superlibrarian 5) Attempt to change the logged in branch This change should succeed 6) Log in as a non-superlibrarian account 7) Attempt to change the logged n branch This should not be allowed, as per Koha's current behavior Signed-off-by: Owen Leonard <oleonard@myacpl.org> I guess this doesn't do any harm even though the practical motivations behind it, as described in the bug, seem otherwise solvable. If SingleBranchMode is supposed to prevent librarians from switching their logged in library why can they choose their library when they first log in? Was SingleBranchMode supposed to only affect the OPAC originally? Or should the login form be modified? This seems to be a band-aid on a poorly-implemented feature. Created attachment 18093 [details] [review] [PASSED QA] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library Currently, when SingleBranchMode is enabled, nobody can change the logged in library in Koha. To change it requires disable SingleBranchMode, switching the library, and re-enabling it. It seems reasonable to allow superlibrarians to switch the logged in library even if SingleBranchMode is enabled. Test Plan: 1) Apply this patch 3) Enable SingleBranchMode 4) Log in as a superlibrarian 5) Attempt to change the logged in branch This change should succeed 6) Log in as a non-superlibrarian account 7) Attempt to change the logged n branch This should not be allowed, as per Koha's current behavior Signed-off-by: Owen Leonard <oleonard@myacpl.org> I guess this doesn't do any harm even though the practical motivations behind it, as described in the bug, seem otherwise solvable. If SingleBranchMode is supposed to prevent librarians from switching their logged in library why can they choose their library when they first log in? Was SingleBranchMode supposed to only affect the OPAC originally? Or should the login form be modified? This seems to be a band-aid on a poorly-implemented feature. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works as decribed. As this only adds a check for a superlibrarian it seems safe and should not interfere with normal staff accounts. I will open another bug for some inconsistency I found testing this: You can now switch the library once you are logged in, but while the library pull down also shows on the login page, the selection there is not saved. This patch has been pushed to master and 3.12.x. |