| Summary: | Correct the documentation for the C4:Members sub: IsMemberBlocked | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Developer documentation | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 10063: Correct documentation of C4::Members::IsMemberBlocked
Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Bug 10063: Remove outdated FIXME Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Bug 10063: Remove outdated FIXME [PASSED QA] Bug 10063: Correct documentation of C4::Members::IsMemberBlocked [PASSED QA] Bug 10063: Remove outdated FIXME |
||
|
Description
David Cook
2013-04-16 09:26:39 UTC
Created attachment 39972 [details] [review] Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Rephrased documentation a bit, replacing fine days with the more general term restriction. As IsDebarred checks for existing active restrictions. David, is this what you had in mind? If not, you will have to steer me in he right direction with this. (In reply to Katrin Fischer from comment #2) > David, is this what you had in mind? If not, you will have to steer me in he > right direction with this. No idea :). I should've written a better comment 2 years ago when I reported it. Comment on attachment 39972 [details] [review] Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Review of attachment 39972 [details] [review]: ----------------------------------------------------------------- ::: C4/Members.pm @@ +531,4 @@ > > FIXME: this needs to be split into two functions; a potential block > based on the number of current overdue items could be orthogonal > +to a block based on whether the patron has any restrictions. I'm not sure this FIXME is relevant any more. We have the Debarment function and surely there is a function in C4::Overdues which can be used to get the issues overdue count. Created attachment 40145 [details] [review] Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Rephrased documentation a bit, replacing fine days with the more general term restriction. As IsDebarred checks for existing active restrictions. TEST PLAN --------- 1) apply patch 2) git diff origin/master -- do the changes make sense 3) perldoc C4::Members -- look for the IsMemberBlocked. -- Does it reflect current state 4) koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> (In reply to M. Tompsett from comment #4) > Comment on attachment 39972 [details] [review] [review] > Bug 10063: Correct documentation of C4::Members::IsMemberBlocked > > Review of attachment 39972 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: C4/Members.pm > @@ +531,4 @@ > > > > FIXME: this needs to be split into two functions; a potential block > > based on the number of current overdue items could be orthogonal > > +to a block based on whether the patron has any restrictions. > > I'm not sure this FIXME is relevant any more. We have the Debarment function > and surely there is a function in C4::Overdues which can be used to get the > issues overdue count. Same here, shouldn't we remove this FIXME? I was not sure so I left it - if you want, please go ahead and remove it! Created attachment 40377 [details] [review] Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Rephrased documentation a bit, replacing fine days with the more general term restriction. As IsDebarred checks for existing active restrictions. TEST PLAN --------- 1) apply patch 2) git diff origin/master -- do the changes make sense 3) perldoc C4::Members -- look for the IsMemberBlocked. -- Does it reflect current state 4) koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Created attachment 40378 [details] [review] Bug 10063: Remove outdated FIXME Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Created attachment 40390 [details] [review] Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Rephrased documentation a bit, replacing fine days with the more general term restriction. As IsDebarred checks for existing active restrictions. TEST PLAN --------- 1) apply patch 2) git diff origin/master -- do the changes make sense 3) perldoc C4::Members -- look for the IsMemberBlocked. -- Does it reflect current state 4) koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Created attachment 40391 [details] [review] Bug 10063: Remove outdated FIXME Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Created attachment 40392 [details] [review] [PASSED QA] Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Rephrased documentation a bit, replacing fine days with the more general term restriction. As IsDebarred checks for existing active restrictions. TEST PLAN --------- 1) apply patch 2) git diff origin/master -- do the changes make sense 3) perldoc C4::Members -- look for the IsMemberBlocked. -- Does it reflect current state 4) koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 40393 [details] [review] [PASSED QA] Bug 10063: Remove outdated FIXME Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patches pushed to master. Thanks Katrina! Pushed to 3.20.x will be in 3.20.2 |