| Summary: | Style invoice edit form according to standard structure | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/acqui/invoice.pl?invoiceid=X | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 10046 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 10065 - Style invoice edit form according to standard structure
Bug 10065 - Style invoice edit form according to standard structure Bug 10065 - Style invoice edit form according to standard structure |
||
|
Description
Owen Leonard
2013-04-16 13:08:05 UTC
Created attachment 17489 [details] [review] Bug 10065 - Style invoice edit form according to standard structure The structure of the invoice edit form does not match that of similar forms in the staff client. This patch alters it to be consistent. To test you must also have the patch for Bug 10046 applied. Go to Acquisitions -> Invoices and search for invoices. Click an invoice to view/edit details. The form displaying fields for shipment date, billing date, etc. should look correct and work correctly. Created attachment 17535 [details] [review] Bug 10065 - Style invoice edit form according to standard structure The structure of the invoice edit form does not match that of similar forms in the staff client. This patch alters it to be consistent. To test you must also have the patch for Bug 10046 applied. Go to Acquisitions -> Invoices and search for invoices. Click an invoice to view/edit details. The form displaying fields for shipment date, billing date, etc. should look correct and work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> QA Comment:
Standardize the form on the invoice page.
I don't understand the indentation structure:
<ol>
<li><label>text</label>
[8spaces]<input/></li>
<ol>
I prefer:
<ol>
<li>
<label>text</label>
<input/>
<li>
</ol>
As long as we don't have coding guidelines for template structures, I cannot fail QA for a personal taste :)
So I mark it as passed qa.
Created attachment 17543 [details] [review] Bug 10065 - Style invoice edit form according to standard structure The structure of the invoice edit form does not match that of similar forms in the staff client. This patch alters it to be consistent. To test you must also have the patch for Bug 10046 applied. Go to Acquisitions -> Invoices and search for invoices. Click an invoice to view/edit details. The form displaying fields for shipment date, billing date, etc. should look correct and work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master and 3.12.x. |