Summary: | IndependentBranches error message missing the library name | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | bgkriegel, chris, gmcharlt, jonathan.druart, kyle.m.hall, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/circ/circulation.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
error
Bug 10081 - IndependentBranches error message missing the library name Bug 10081: add library name to IndependentBranches error message Bug 10081: add library name to IndependentBranches error message |
I can't tell what HomeOrHoldingBranch has to do with this bug. I can only trigger the error if IndependentBranches is on and I'm checking out an item from another branch. Created attachment 20321 [details] [review] Bug 10081 - IndependentBranches error message missing the library name With IndependentBranches turned on, if you try to check out an item which belongs to another library you will get an error message which is missing the library name. This patch corrects the problem by passing the necessary variable to the template and outputting the library name using the KohaBranchName TT plugin. To test, turn on IndependentBranches and try to check out an item belonging to another library (note that you must test with a staff user who is not a superlibrarian). The error message you see should include the name of the library to which the item belongs: "This item belongs to Nelsonville and cannot be checked out from this location." Checkouts of items belonging to the library should be unaffected. Created attachment 20331 [details] [review] Bug 10081: add library name to IndependentBranches error message With IndependentBranches turned on, if you try to check out an item which belongs to another library you will get an error message which is missing the library name. This patch corrects the problem by passing the necessary variable to the template and outputting the library name using the KohaBranchName TT plugin. To test, turn on IndependentBranches and try to check out an item belonging to another library (note that you must test with a staff user who is not a superlibrarian). The error message you see should include the name of the library to which the item belongs: "This item belongs to Nelsonville and cannot be checked out from this location." Checkouts of items belonging to the library should be unaffected. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 20504 [details] [review] Bug 10081: add library name to IndependentBranches error message With IndependentBranches turned on, if you try to check out an item which belongs to another library you will get an error message which is missing the library name. This patch corrects the problem by passing the necessary variable to the template and outputting the library name using the KohaBranchName TT plugin. To test, turn on IndependentBranches and try to check out an item belonging to another library (note that you must test with a staff user who is not a superlibrarian). The error message you see should include the name of the library to which the item belongs: "This item belongs to Nelsonville and cannot be checked out from this location." Checkouts of items belonging to the library should be unaffected. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Owen! This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Owen! Pushed to 3.10.x, will be in 3.10.11 |
Created attachment 17557 [details] error See attached. When you have HomeOrHoldingBranch set to home library you get an error when you try to check the item out at another branch - this is good, but the error is missing a library name I think cause it's not a sentence: "This item belongs to and cannot be issued from this location." I think it should be : "This item belongs to HOMEBRANCH and cannot be issued from this location."