Summary: | the ordered and spent page display the itemtype code | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gitbot, gmcharlt, kyle, mathsabypro, sandboxes, srdjan |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 10090: Add itemtype description instead of code
[SIGNED-OFF] Bug 10090: Add itemtype description instead of code Bug 10090: Add itemtype description instead of code Bug 10090: Add itemtype description instead of code Bug 10090: Add itemtype description instead of code [PASSED QA] Bug 10090: Add itemtype description instead of code |
Description
Jonathan Druart
2013-04-22 07:50:46 UTC
Created attachment 17574 [details] [review] Bug 10090: Add itemtype description instead of code On ordered.pl and spent.pl, the itemtype codes are displayed, instead of descriptions. Links for the ordernumber should be changed. In ordered.pl, we are redirected to the receive page. In spent.pl, the links are deleted. Test plan: Go on the ordered.pl and spent.pl pages and check that the itemtype column is filled with the itemtype descriptions. Created attachment 18599 [details] [review] [SIGNED-OFF] Bug 10090: Add itemtype description instead of code On ordered.pl and spent.pl, the itemtype codes are displayed, instead of descriptions. Links for the ordernumber should be changed. In ordered.pl, we are redirected to the receive page. In spent.pl, the links are deleted. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Hi Jonathan, I just checked master to find out which plugins we now got and there already is an ItemTypes plugin (and 2 plugins for authorised values?) Could you take a look? Created attachment 19061 [details] [review] Bug 10090: Add itemtype description instead of code On ordered.pl and spent.pl, the itemtype codes are displayed, instead of descriptions. Links for the ordernumber should be changed. In ordered.pl, we are redirected to the receive page. In spent.pl, the links are deleted. The last patch deals with the existing plugin. Hi What do you mean by itemtypes, the items types defined at item level (useless for my library), or at biblio level? Mathieu (In reply to mathieu saby from comment #6) > Hi > What do you mean by itemtypes, the items types defined at item level > (useless for my library), or at biblio level? It is hardcoded, it is items.itype. Well, I will take a look, but adding biblioitems.itemtype some day could be nice too (by the way, the name of this field is sometime confusing...) Mathieu Patch applied cleanly, go forth and signoff Patch tested with a sandbox, by Broust <jean-manuel.broust@gmail.com> Created attachment 26013 [details] [review] Bug 10090: Add itemtype description instead of code On ordered.pl and spent.pl, the itemtype codes are displayed, instead of descriptions. Links for the ordernumber should be changed. In ordered.pl, we are redirected to the receive page. In spent.pl, the links are deleted. Signed-off-by: Broust <jean-manuel.broust@gmail.com> The description displays nicely, but I think changing the links is not quite right. I will try to explain: Ordered: on the 'Ordered' page the link now goes directly to the receive page, but it's missing the invoiceid and the biblionumber, so the display is not quite right and receiving it like this would cause problems because of the missing invoice. Spent: Removing the link seems ok to me, because of the reason given above. One thing we could do would be link to the invoice it was received in. Maybe just change the descriptions with this bug, and leave improving the links to a separate one? Created attachment 26284 [details] [review] Bug 10090: Add itemtype description instead of code On ordered.pl and spent.pl, the itemtype codes are displayed, instead of descriptions. Links for the ordernumber should be changed. In ordered.pl, we are redirected to the receive page. In spent.pl, the links are deleted. Signed-off-by: Broust <jean-manuel.broust@gmail.com> Revisited patch: The link to orderreceive was broken, so I undo the changes. Created attachment 26304 [details] [review] [PASSED QA] Bug 10090: Add itemtype description instead of code On ordered.pl and spent.pl, the itemtype codes are displayed, instead of descriptions. Links for the ordernumber should be changed. In ordered.pl, we are redirected to the receive page. In spent.pl, the links are deleted. Signed-off-by: Broust <jean-manuel.broust@gmail.com> Revisited patch: The link to orderreceive was broken, so I undo the changes. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works alright, itemtype descriptions are shown. The removed link was potentially 'dangerous' as you shouldn't get to the receive page for an order, without providing an invoicenumber first. Passes all tests and QA script. Pushed to master. Thanks, Jonathan! Pushed to 3.14.x, will be in 3.14.10 Picked for 3.12.15! |