| Summary: | Hide framework selection when importing staged authority records | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Templates | Assignee: | David Cook <dcook> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 10097 - If importing authority records, don't show text relating to bibliographic records
Bug 10097 - Hide framework selection when importing staged authority records [PASSED QA] Bug 10097 - Hide framework selection when importing staged authority records |
||
|
Description
David Cook
2013-04-23 03:00:21 UTC
Created attachment 17602 [details] [review] Bug 10097 - If importing authority records, don't show text relating to bibliographic records Test Plan: Before applying patch... 1) Find yourself an authority record. I recommend downloading your favourite author from: http://authorities.loc.gov/ 2) Stage MARC for import. Choose "Authority" as your record type. 3) Go to "Manage staged records" 4) Underneath the button "Import this batch into the catalog", you should see the text "Add new bibliographic records into this framework:" followed by a drop-down of the available frameworks. Optionally) You can also try this for bibliographic records. You'll find the same. After applying the patch... 5) Repeat steps 2 and 3. 6) Underneath the button "Import this batch into the catalog", you should just see a table listing your MARC record(s). 7) Stage MARC for import. Choose "Bibliographic" as your record type. 8) Go to "Manage staged records". 9) You should find step 4 still to be true (i.e. the "Add new bibliographic..." text should still be there). Created attachment 17725 [details] [review] Bug 10097 - Hide framework selection when importing staged authority records Currently, when importing authority records using the "Manage staged MARC records" tool, it will show the text "Add new bibliographic records into this framework:" followed by a drop-down menu of possible frameworks. Since these are bibliographic frameworks and we're importing authority records which do not use them, we have no need to show this information. I'm proposing just a little patch to display this info only for bibliographic records. From my tests, everything seems to work fine without this text and the drop-down, although I've only uploaded one MARC21 authority record at a time. -- Test Plan: Before applying patch... 1) Find yourself an authority record. I recommend downloading your favourite author from: http://authorities.loc.gov/ 2) Stage MARC for import. Choose "Authority" as your record type. 3) Go to "Manage staged records" 4) Underneath the button "Import this batch into the catalog", you should see the text "Add new bibliographic records into this framework:" followed by a drop-down of the available frameworks. Optionally) You can also try this for bibliographic records. You'll find the same. After applying the patch... 5) Repeat steps 2 and 3. 6) Underneath the button "Import this batch into the catalog", you should just see a table listing your MARC record(s). 7) Stage MARC for import. Choose "Bibliographic" as your record type. 8) Go to "Manage staged records". 9) You should find step 4 still to be true (i.e. the "Add new bibliographic..." text should still be there). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 17781 [details] [review] [PASSED QA] Bug 10097 - Hide framework selection when importing staged authority records Currently, when importing authority records using the "Manage staged MARC records" tool, it will show the text "Add new bibliographic records into this framework:" followed by a drop-down menu of possible frameworks. Since these are bibliographic frameworks and we're importing authority records which do not use them, we have no need to show this information. I'm proposing just a little patch to display this info only for bibliographic records. From my tests, everything seems to work fine without this text and the drop-down, although I've only uploaded one MARC21 authority record at a time. -- Test Plan: Before applying patch... 1) Find yourself an authority record. I recommend downloading your favourite author from: http://authorities.loc.gov/ 2) Stage MARC for import. Choose "Authority" as your record type. 3) Go to "Manage staged records" 4) Underneath the button "Import this batch into the catalog", you should see the text "Add new bibliographic records into this framework:" followed by a drop-down of the available frameworks. Optionally) You can also try this for bibliographic records. You'll find the same. After applying the patch... 5) Repeat steps 2 and 3. 6) Underneath the button "Import this batch into the catalog", you should just see a table listing your MARC record(s). 7) Stage MARC for import. Choose "Bibliographic" as your record type. 8) Go to "Manage staged records". 9) You should find step 4 still to be true (i.e. the "Add new bibliographic..." text should still be there). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Small template change, passes all tests. This patch has been pushed to master and 3.12.x. Pushed to 3.10.x will be in 3.10.6 |