Summary: | Problems with diacritics in saved SQL reports | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Reports | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, m.de.rooy, mathsabypro |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10010: Problems with diacritics in saved SQL reports
Bug 10110 Followup for Acquisition.pm Bug 10110: Problems with diacritics in saved SQL reports Bug 10110 Followup for Acquisition.pm Bug 10110: Problems with diacritics in saved SQL reports [PASSED QA] Bug 10110: Problems with diacritics in saved SQL reports Bug 10110 Followup for Acquisition.pm [PASSED QA] Bug 10110 Followup for Acquisition.pm |
Description
Katrin Fischer
2013-04-25 05:54:16 UTC
Created attachment 17680 [details] [review] Bug 10010: Problems with diacritics in saved SQL reports Adds decoding for cgi params (for completeness). Apparently, the NAME attribute of DBI statement handle has a UTF8 bug. Fixing this by decoding the returned column names. Did this in a shared routine. Created attachment 17682 [details] [review] Bug 10110 Followup for Acquisition.pm Adding a FIXE at a line that uses $sth->{NAME} for possible utf8 problems. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 17683 [details] [review] Bug 10110: Problems with diacritics in saved SQL reports Adds decoding for cgi params (for completeness). Apparently, the NAME attribute of DBI statement handle has a UTF8 bug. Fixing this by decoding the returned column names. Did this in a shared routine. Created attachment 17704 [details] [review] Bug 10110 Followup for Acquisition.pm Adding a FIXE at a line that uses $sth->{NAME} for possible utf8 problems. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 17705 [details] [review] Bug 10110: Problems with diacritics in saved SQL reports Adds decoding for cgi params (for completeness). Apparently, the NAME attribute of DBI statement handle has a UTF8 bug. Fixing this by decoding the returned column names. Did this in a shared routine. http://bugs.koha-community.org/show_bug.cgi?id=10110 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 17743 [details] [review] [PASSED QA] Bug 10110: Problems with diacritics in saved SQL reports Adds decoding for cgi params (for completeness). Apparently, the NAME attribute of DBI statement handle has a UTF8 bug. Fixing this by decoding the returned column names. Did this in a shared routine. http://bugs.koha-community.org/show_bug.cgi?id=10110 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Copying test plan from bug report: Example SQL: select branchname as "Bibliothek (üöä)", branchname "Bibiothek (üäa)", branchname from branches where branchcode = <<Bibliothekskürzel|branches>> 1) Create report with given example SQL or your own including some diacritics in the columnnames 2) Save the report and run it 3) Verify column names are broken before patch, but fixed after.. All tests and QA script pass. Created attachment 17744 [details] [review] Bug 10110 Followup for Acquisition.pm Adding a FIXE at a line that uses $sth->{NAME} for possible utf8 problems. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 17745 [details] [review] [PASSED QA] Bug 10110 Followup for Acquisition.pm Adding a FIXE at a line that uses $sth->{NAME} for possible utf8 problems. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Adds a comment, no danger from that. This patch has been pushed to master and 3.12.x. Pushed to 3.10.x will be in 3.10.6 *** Bug 11437 has been marked as a duplicate of this bug. *** |