Summary: | Layout on basket summary page a bit inconsistent | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, mirko |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
screenshot of basket summary page
Bug 10111 - Layout on basket summary page a bit inconsistent Bug 10111 - Layout on basket summary page a bit inconsistent Bug 10111 - Followup Layout on basket summary page a bit inconsistent [PASSED QA] Bug 10111 - Layout on basket summary page a bit inconsistent |
Created attachment 17685 [details] [review] Bug 10111 - Layout on basket summary page a bit inconsistent Some details in the summary of basket information were not marked up consistently with others on the page. This patch makes the markup consistent for a consistent appearance. To test, view a basket in Acquisitions which is part of a basketgroup. Information should be displayed consistently for baksets in both open and closed basket groups. Created attachment 17688 [details] [review] Bug 10111 - Layout on basket summary page a bit inconsistent Some details in the summary of basket information were not marked up consistently with others on the page. This patch makes the markup consistent for a consistent appearance. To test, view a basket in Acquisitions which is part of a basketgroup. Information should be displayed consistently for baksets in both open and closed basket groups. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Works as expected QA comment: Owen, I'm not sure at all but I suspect 1 extra li tag. I got: - If basket is not in a bg: the "basket group" label and select (+ input) are not on the same line. - If basket is in a opened bg: idem - If basket is in a closed bg: the "basket group" label and the text ( "basketname (closed)") are on the same line. Extra li would be at lines 213 and 214. I will submit a patch, mark it as obsolete if it is the expected behavior, else sign off it. Marked as Failed QA. Created attachment 17694 [details] [review] Bug 10111 - Followup Layout on basket summary page a bit inconsistent Remove extra li tag. Comment on attachment 17694 [details] [review] Bug 10111 - Followup Layout on basket summary page a bit inconsistent It is a little strange to have the input in a separate <li> than the label, but I think it's more readable that way, especially in a medium-sized browser window. Created attachment 17861 [details] [review] [PASSED QA] Bug 10111 - Layout on basket summary page a bit inconsistent Some details in the summary of basket information were not marked up consistently with others on the page. This patch makes the markup consistent for a consistent appearance. To test, view a basket in Acquisitions which is part of a basketgroup. Information should be displayed consistently for baksets in both open and closed basket groups. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Works as expected Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template change only, works nicely. This patch has been pushed to master and 3.12.x. Pushed to 3.10.x will be in 3.10.6 |
Created attachment 17662 [details] screenshot of basket summary page Looking at the basket header section of the basket summary page I think we should have all labels in bold and are missing some lins between the lines on the right side of the display. And while someone is in there - it would be nice if some of the information could be easily hidden using CSS as not all libraries will want to use the multi-branch options for billing and delivery places.