Summary: | Hiding advanced search in Orders search tab removes plus button | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, mirko |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10115 - Hiding advanced search in Orders search tab removes plus button
Bug 10115 - Hiding advanced search in Orders search tab removes plus button Bug 10115 - Hiding advanced search in Orders search tab removes plus button |
Description
Jared Camins-Esakov
2013-04-25 11:23:54 UTC
Created attachment 17684 [details] [review] Bug 10115 - Hiding advanced search in Orders search tab removes plus button The logic of the JavaScript for showing and hiding additional options in the orders search form wasn't quite right, resulting in the +/- control being hidden incorrectly. This patch corrects and simplifies the JS in order to fix the problem. To test: - Open any page in Acquisitions which shows the orders search form in the header search bar (for instance, Acquisitions home). - Open the orders search tab and click on the "+" to show more options. - Click the "-" to hide the additional options. The additional options should now be hidden and the "+" displayed. Created attachment 17687 [details] [review] Bug 10115 - Hiding advanced search in Orders search tab removes plus button The logic of the JavaScript for showing and hiding additional options in the orders search form wasn't quite right, resulting in the +/- control being hidden incorrectly. This patch corrects and simplifies the JS in order to fix the problem. To test: - Open any page in Acquisitions which shows the orders search form in the header search bar (for instance, Acquisitions home). - Open the orders search tab and click on the "+" to show more options. - Click the "-" to hide the additional options. The additional options should now be hidden and the "+" displayed. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Works as expected QA comment: Simple patch, works as expected. Marked as Passed QA. Created attachment 17695 [details] [review] Bug 10115 - Hiding advanced search in Orders search tab removes plus button The logic of the JavaScript for showing and hiding additional options in the orders search form wasn't quite right, resulting in the +/- control being hidden incorrectly. This patch corrects and simplifies the JS in order to fix the problem. To test: - Open any page in Acquisitions which shows the orders search form in the header search bar (for instance, Acquisitions home). - Open the orders search tab and click on the "+" to show more options. - Click the "-" to hide the additional options. The additional options should now be hidden and the "+" displayed. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Works as expected This patch has been pushed to master and 3.12.x. |