Summary: | Input fields for branch configuration are too short | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Campbell Reid-Tait <campbellreidtait> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | campbellreidtait, gmcharlt, paola.rossi, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10130 - Input fields for branch configuration are too short
Signed off patch [PASSED QA] Bug 10130 - Input fields for branch configuration are too short |
Description
Katrin Fischer
2013-04-26 14:31:53 UTC
Created attachment 20486 [details] [review] Bug 10130 - Input fields for branch configuration are too short Most input fields in the library entry form (admin/branches.pl) have no explicit with, so they display with a browser-default width. This patch gives explicit widths to those fields, giving more room for entry. Other fields have been given an explicit width and/or maxwidth according to the database table structure. To test, add or edit a library in Administration -> Libraries and Groups. Form fields should be more comfortable for entry, and add/edit actions should complete correctly. Created attachment 20681 [details] [review] Signed off patch Created attachment 20688 [details] [review] [PASSED QA] Bug 10130 - Input fields for branch configuration are too short Most input fields in the library entry form (admin/branches.pl) have no explicit with, so they display with a browser-default width. This patch gives explicit widths to those fields, giving more room for entry. Other fields have been given an explicit width and/or maxwidth according to the database table structure. To test, add or edit a library in Administration -> Libraries and Groups. Form fields should be more comfortable for entry, and add/edit actions should complete correctly. Signed-off-by: Campbell Reid-Tait <campbellreidtait@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template changes only, works nicely. Tested editing and adding libraries in administration. Maybe we could move the opac info editor field a bit to the right, to match where the other fields begin. But this works nicely and long library names and addresses shouldn't be a problem now :) I also tested the patch on Windows 7 professional, browsers: Mozilla FF 23, Google Chrome 29 and Explorer 9. For me it's OK. Pushed to master. Thanks, Owen! This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Owen! |