Description
Katrin Fischer
2013-04-26 15:11:12 UTC
This would be rather useful in a few of the use-cases where I'm encountering individual libraries contributing marc data as part of a government driven library consortium. These libraries are being tried as branches. Branch specific MarcOrgCode could easy a lot of pain. *** Bug 18751 has been marked as a duplicate of this bug. *** Created attachment 64183 [details] [review] Bug 10132 - database changes Created attachment 64184 [details] [review] Bug 10132 - database result class change Created attachment 64185 [details] [review] Bug 10132 - add tests Created attachment 64186 [details] [review] Bug 10132 - admin pages changes Created attachment 64187 [details] [review] Bug 10132 - Ability to set MARC Organization Code at library level Test plan: 0. Apply patches 1. Update database 2. Go to administration -> libraries, try to update some library and fill in some value into Marc Organization code field 3. Save this library and edit again - the code should be stored correctly 4. Go to system preferences and fill in some value into MARCOrgCode preference, note there is enhanced description mentioning the ability to set organization code on library level 5. Set active library to the one with own org code stored 6. Go to cataloguing, create new empty record and click into field 003 - there should be the code you filled for that library 7. Set active library to one withou marc org code 8. Go to cataloguing, create new empty record and click into field 003 - there should be the code from system preference 9. Go to system preferences again and set AutoCreateAuthorities to 'generate' and BiblioAddsAuthorities to 'allow' 10. Go to cataloguing and create some biblio record, fill in any author in to create its authority record, save the biblio 11. Go to authorities and find this created authority, go to details and check the fields: 003, 040$a, 040$c, 670$a - there should be used right org code 12. prove t/db_dependent/AuthoritiesMarc.t t/db_dependent/Biblio.t t/db_dependent/Koha/Libraries.t I have applied the patch, and go through the test plan, including tests, and everything goes as it expected nice work! Created attachment 67060 [details] [review] Bug 10132: Database changes Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67061 [details] [review] Bug 10132: DBIC update Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67062 [details] [review] Bug 10132: Unit tests Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67063 [details] [review] Bug 10132: Admin pages changes Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67064 [details] [review] Bug 10132: Add ability to set MARC Organization Code at library level Test plan: 0. Apply patches 1. Update database 2. Go to administration -> libraries, try to update some library and fill in some value into Marc Organization code field 3. Save this library and edit again - the code should be stored correctly 4. Go to system preferences and fill in some value into MARCOrgCode preference, note there is enhanced description mentioning the ability to set organization code on library level 5. Set active library to the one with own org code stored 6. Go to cataloguing, create new empty record and click into field 003 - there should be the code you filled for that library 7. Set active library to one withou marc org code 8. Go to cataloguing, create new empty record and click into field 003 - there should be the code from system preference 9. Go to system preferences again and set AutoCreateAuthorities to 'generate' and BiblioAddsAuthorities to 'allow' 10. Go to cataloguing and create some biblio record, fill in any author in to create its authority record, save the biblio 11. Go to authorities and find this created authority, go to details and check the fields: 003, 040$a, 040$c, 670$a - there should be used right org code 12. prove t/db_dependent/AuthoritiesMarc.t t/db_dependent/Biblio.t t/db_dependent/Koha/Libraries.t Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67065 [details] [review] Bug 10132: (QA followup) Organize tests in subtest Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67066 [details] [review] Bug 10132: (QA followup) Add POD to ->get_effective_marcorgcode Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67067 [details] [review] Bug 10132: (QA followup) Open LOC URL on a separate window Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67208 [details] [review] Bug 10132: Simplify code, call the method only once Created attachment 67211 [details] [review] Bug 10132: Simplify code, call the method only once Does it make sense to display the "MARC Organization Code" input field for UNIMARC users? Pushed to master for 17.11, thanks to everybody involved! Enhancement not pushed to 17.05.x |