|
Description
Mathieu Saby
2013-05-02 09:03:21 UTC
(The design of advanced search page could be improved too : lot of wasted space, need to scroll for accessing the buttons.... But it deserves an other bug) M. Saby Created attachment 50783 [details] [review] Bug 10171: Add a search box include on advanced search and item search pages This patch creates a new file: adv-search.inc. This search include has no catalog search (as it makes no sense to have the catalog search tab on the advanced search page). The item search page uses home-search.inc (with catalog search) as the catalog search is different to the item search. To test: 1) Go to Search (advanced search) 2) Confirm search header is there with no catalog search tab and works as expected 3) Go to item search 4) Confirm search header is there with catalog search tab and works as expected Sponsored-by: Catalyst IT (In reply to mathieu saby from comment #1) > (The design of advanced search page could be improved too : lot of wasted > space, need to scroll for accessing the buttons.... But it deserves an other > bug) > M. Saby I have created Bug 16363 and Bug 16364 for this :) Created attachment 50858 [details] [review] [SIGNED-OFF] Bug 10171: Add a search box include on advanced search and item search pages This patch creates a new file: adv-search.inc. This search include has no catalog search (as it makes no sense to have the catalog search tab on the advanced search page). The item search page uses home-search.inc (with catalog search) as the catalog search is different to the item search. To test: 1) Go to Search (advanced search) 2) Confirm search header is there with no catalog search tab and works as expected 3) Go to item search 4) Confirm search header is there with catalog search tab and works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 50859 [details] [review] Bug 10171 [Follow-up] Add a header in Advanced Search (staff interface) This patch re-indents the new include file because it's not often you get to help a new file come into the world, it should be indented nicely. Created attachment 50874 [details] [review] Bug 10171: Add a search box include on advanced search and item search pages This patch creates a new file: adv-search.inc. This search include has no catalog search (as it makes no sense to have the catalog search tab on the advanced search page). The item search page uses home-search.inc (with catalog search) as the catalog search is different to the item search. To test: 1) Go to Search (advanced search) 2) Confirm search header is there with no catalog search tab and works as expected 3) Go to item search 4) Confirm search header is there with catalog search tab and works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested together with follow up patch, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 50875 [details] [review] Bug 10171 [Follow-up] Add a header in Advanced Search (staff interface) This patch re-indents the new include file because it's not often you get to help a new file come into the world, it should be indented nicely. Signed-off-by: Marc Véron <veron@veron.ch> I've tested this on top of bug 16363 to see how they work together. No conflicts and works nicely! Created attachment 50906 [details] [review] [PASSED QA] Bug 10171: Add a search box include on advanced search and item search pages This patch creates a new file: adv-search.inc. This search include has no catalog search (as it makes no sense to have the catalog search tab on the advanced search page). The item search page uses home-search.inc (with catalog search) as the catalog search is different to the item search. To test: 1) Go to Search (advanced search) 2) Confirm search header is there with no catalog search tab and works as expected 3) Go to item search 4) Confirm search header is there with catalog search tab and works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested together with follow up patch, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 50907 [details] [review] [PASSED QA] Bug 10171 [Follow-up] Add a header in Advanced Search (staff interface) This patch re-indents the new include file because it's not often you get to help a new file come into the world, it should be indented nicely. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master! Should be in the May 2016 release. Arigato Aleisha! Created attachment 51112 [details] [review] Bug 10171: (QA followup) Make search tests use the right form This bug removed the search tab from the main search box, so the tests that use /cgi-bin/koha/catalogue/search.pl for searching, should use the advanced search box instead. To test: - Run $ prove t/db_dependent/www/search_utf8.t => FAIL: Several tests related to searching on the intranet interface fail. - Apply the patch - Run $ prove t/db_dependent/www/search_utf8.t => SUCCESS: Tests pass - Be happy Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> @RM, please push the last followup to adjust tests to the new page layout. Created attachment 51184 [details] [review] Bug 10171: (QA followup) Make search tests use the right form This bug removed the search tab from the main search box, so the tests that use /cgi-bin/koha/catalogue/search.pl for searching, should use the advanced search box instead. To test: - Run $ prove t/db_dependent/www/search_utf8.t => FAIL: Several tests related to searching on the intranet interface fail. - Apply the patch - Run $ prove t/db_dependent/www/search_utf8.t => SUCCESS: Tests pass - Be happy Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Followup pushed to master for 16.05, thanks Tomas! |