| Summary: | Typos in plugins for 006 and 008 in MARC21 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Cataloging | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | bgkriegel, chrish, gmcharlt, m.de.rooy, nengard, tomascohen |
| Version: | 3.14 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 6709 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 10178 - Typos in plugins for 006 and 008 in MARC21
Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Bug 10178 - Typos in plugins for 006 and 008 in MARC21 [PASSED QA] Bug 10178 - Typos in plugins for 006 and 008 in MARC21 |
||
|
Description
Katrin Fischer
2013-05-02 21:37:19 UTC
008: <Value code="r"><description>Instrutional materials</description></Value> 008: <Value code="w"><description>Law reorts and digests</description></Value> <Value code="z"><description>Teatries</description></Value> Created attachment 17912 [details] [review] Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 008 Music on April 2013. And a missing value in 006 Consider this patch as an interim fix. I will re-check all values. As it change strings, it will not be considered right now. So, no need to sign yet. Created attachment 17950 [details] [review] Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 006/8 Music on April 2013. And 3 missing values in 006. Revised descriptions and labels, source LOC page. Strings spell checked. To test: 1) Apply the patch 2) Test that MARC21 006 and 008 value builders works properly. Small string changes. Created attachment 18051 [details] [review] Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 006/8 Music on April 2013. And 3 missing values in 006. Revised descriptions and labels, source LOC page. Strings spell checked. To test: 1) Apply the patch 2) Test that MARC21 006 and 008 value builders works properly. Small string changes. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Created attachment 18086 [details] [review] [PASSED QA] Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 006/8 Music on April 2013. And 3 missing values in 006. Revised descriptions and labels, source LOC page. Strings spell checked. To test: 1) Apply the patch 2) Test that MARC21 006 and 008 value builders works properly. Small string changes. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> XML changes only, passes all tests. Contains string changes, so should go into 3.14. *** Bug 10242 has been marked as a duplicate of this bug. *** Pushed to master. Thanks, Bernardo! The typo fixes aside, because of the April 2013 updates to the 006 for music, this patch should be backported to stable. Pushed to 3.12.x. This will be in 3.12.1. Thanks! Note: this probably doesn't need to be applied to 3.10.x and older branches. This patch corrects or updates strings that are already in 3.10.6, I will apply it. Pushed to 3.10.x, will be in 3.10.7 A quick look through this patch shows that it seems to be applicable for 3.8.x, however the patch in its current form does not apply cleanly. It is possible for you to rebase and submit a version for 3.8.x? Chris, to apply this you need first Bug 6709 (and one more at least, read the final comments). Thanks Bernardo I was able to get this to apply cleanly after applying both patches on 9358, both patches on 6709 and then this patch. Pushed to 3.8.x and will be in 3.8.14 Thanks again :) |