Summary: | 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Mathieu Saby <mathsabypro> |
Component: | Templates | Assignee: | Mathieu Saby <mathsabypro> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | trivial | ||
Priority: | P5 - low | CC: | bgkriegel, chrish, gmcharlt, tomascohen |
Version: | 3.14 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt
[SIGNED-OFF] Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt [PASSED QA] Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt |
Description
Mathieu Saby
2013-05-04 09:33:19 UTC
Created attachment 17946 [details] [review] Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt This patch close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt. To test : - in a UNIMARC Koha instance, edit a record - open the plugin for 115a subfield - check the "Form of release - visual projection, motion picture" option list is correct, especially the value "other film type" - ope the plugin for 116 field - check the "Technique (prints) 2" option list is correct, especially the value "lithography" M. Saby Created attachment 18047 [details] [review] [SIGNED-OFF] Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt This patch close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt. To test : - in a UNIMARC Koha instance, edit a record - open the plugin for 115a subfield - check the "Form of release - visual projection, motion picture" option list is correct, especially the value "other film type" - ope the plugin for 116 field - check the "Technique (prints) 2" option list is correct, especially the value "lithography" Signed-off-by: Owen Leonard <oleonard@myacpl.org> I did not test this in Koha, but it's a simple change of one character which I'm comfortable with signing off on. I don't know if this counts as a string change or not, since the string was previously mixed with a malformed tag. Created attachment 18087 [details] [review] [PASSED QA] Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt This patch close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt. To test : - in a UNIMARC Koha instance, edit a record - open the plugin for 115a subfield - check the "Form of release - visual projection, motion picture" option list is correct, especially the value "other film type" - open the plugin for 116 field - check the "Technique (prints) 2" option list is correct, especially the value "lithography" Signed-off-by: Owen Leonard <oleonard@myacpl.org> I did not test this in Koha, but it's a simple change of one character which I'm comfortable with signing off on. I don't know if this counts as a string change or not, since the string was previously mixed with a malformed tag. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and fixes an obvious problem in the HTML. I checked the po files - currently the strings appear as: "other film type/option> %s " So in theory it's possible to translate them correctly even if the standard templates now are not correct. Probably has to wait for 3.14. Pushed to master. Thanks, Mathieu! Pushed to 3.12.x. Will be in 3.12.1. Thanks! Pushed to 3.10.x. Will be in 3.10.7. Pushed to 3.8.x, will be in 3.8.14. |