Summary: | koha-*-zebra scripts are expected to run without warnings if no instance name passed | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Packaging | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, chrish, robin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 10144, 10146, 10159 | ||
Bug Blocks: | |||
Attachments: |
Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed
Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed [PASSED QA] Bug 6399 - tooltip for tags that says 'separate by comma' |
Description
Tomás Cohen Arazi (tcohen)
2013-05-16 14:11:42 UTC
Created attachment 18170 [details] [review] Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed Commented out the code that checks for intance name parameters on the zebra service handling scripts. It restores the original behaviour, while leaving error checking code. Regards To+ Sponsored-by: Universidad Nacionald de Córdoba Created attachment 18171 [details] [review] Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed Commented out the code that checks for intance name parameters on the zebra service handling scripts. It restores the original behaviour, while leaving error checking code. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Created attachment 18176 [details] [review] Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed Commented out the code that checks for intance name parameters on the zebra service handling scripts. It restores the original behaviour, while leaving error checking code. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Signed off by packaging manager and packages related... passing QA. Created attachment 18224 [details] [review] [PASSED QA] Bug 6399 - tooltip for tags that says 'separate by comma' Some sites split tags on spaces, some on commas. Since Koha splits on a comma, we should make that clear to the patron. This patch adds additional text to the "New tag(s)" label. To test, enable TagsEnabled, TagsInputOnDetail, and TagsInputOnList. Click "Add tag" on both OPAC search results and an OPAC detail page. Confirm that the revised label appears correctly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass. There are some more places where we can add tags to multiple records at once, I noted them on the bug. Comment on attachment 18176 [details] [review] Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed Sorry, had the wrong bug number. This patch has been pushed to master and 3.12.x. This patch was shipped into 3.12.0. For 3.8/3.10 maintainers: This patch applies on top of patches for the bugs marked as "depends on". If they happen to be backported too, this one should be applied. Pushed to 3.10.x, will be in 3.10.7 Also pushed all dependencies and related. Thank you for your notes Tomas Pushed to 3.8.x, will be in 3.8.14 along with all dependencies as I think they are a very useful addition. |