Bug 10259

Summary: koha-*-zebra scripts are expected to run without warnings if no instance name passed
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: PackagingAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: bgkriegel, chrish, robin
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 10144, 10146, 10159    
Bug Blocks:    
Attachments: Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed
Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed
Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed
[PASSED QA] Bug 6399 - tooltip for tags that says 'separate by comma'

Description Tomás Cohen Arazi (tcohen) 2013-05-16 14:11:42 UTC
This files where modified to check the parameters for instance names. This sounds fine, but the init scripts expect the start script not to complain on missing instance parameters.
Comment 1 Tomás Cohen Arazi (tcohen) 2013-05-16 14:18:41 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi (tcohen) 2013-05-16 14:57:20 UTC Comment hidden (obsolete)
Comment 3 Robin Sheat 2013-05-16 23:45:45 UTC
Created attachment 18176 [details] [review]
Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed

Commented out the code that checks for intance name parameters on the zebra service handling scripts.
It restores the original behaviour, while leaving error checking code.

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Comment 4 Katrin Fischer 2013-05-18 07:34:31 UTC
Signed off by packaging manager and packages related... passing QA.
Comment 5 Katrin Fischer 2013-05-18 08:19:04 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2013-05-18 08:20:38 UTC
Comment on attachment 18176 [details] [review]
Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed

Sorry, had the wrong bug number.
Comment 7 Jared Camins-Esakov 2013-05-18 10:09:03 UTC
This patch has been pushed to master and 3.12.x.
Comment 8 Tomás Cohen Arazi (tcohen) 2013-05-21 14:29:07 UTC
This patch was shipped into 3.12.0.
Comment 9 Tomás Cohen Arazi (tcohen) 2013-05-21 14:32:07 UTC
For 3.8/3.10 maintainers: This patch applies on top of patches for the bugs marked as "depends on". If they happen to be backported too, this one should be applied.
Comment 10 Bernardo Gonzalez Kriegel 2013-06-14 02:54:35 UTC
Pushed to 3.10.x, will be in 3.10.7

Also pushed all dependencies and related.
Comment 11 Chris Hall 2013-06-17 08:45:17 UTC
Thank you for your notes Tomas

Pushed to 3.8.x, will be in 3.8.14 along with all dependencies as I think they are a very useful addition.