| Summary: | Restricted status doesn't show in OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | OPAC | Assignee: | Rafal Kopaczka <rkopaczka> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 4173 | ||
| Attachments: |
Proposed patch
[PASSED QA] Bug 4173 - Statuses not appearing in the OPAC |
||
|
Description
Katrin Fischer
2013-05-17 05:49:44 UTC
Created attachment 18181 [details] [review] Proposed patch Moved patch and bug description to a new bug. Created attachment 18182 [details] [review] [PASSED QA] Bug 4173 - Statuses not appearing in the OPAC Simply revert order of 2 lines in Items.pm. Previous line write to variable used in next line as function argument. To Test: Give an item a special restricted value, define one if you have to in the authorised values. Observe that, without this patch, statuses are not shown in the OPAC in parentheses. My example was an item that had a restricted value of "Library Staff Only" It should have been shown under status on the detail page of the OPAC, but was not. Apply the patch, observe that restricted values are now shown for your item, for example: Available (Library Staff Only) in the status column. Signed-off-by: Liz Rea <liz@catalyst.net.nz> http://bugs.koha-community.org/show_bug.cgi?id=10266 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and test plan. Simple change fixing a display problem, no string changes. As we are very close to release I suggest to file a separate bug for using the new TT plugin for displaying all item status and use this patch to fix the existing bug in the upcoming release and the older releases. This patch has been pushed to master and 3.12.x. I agree with Katrin- I'd rather see this go into 3.12, as the patch is merely correcting the order of two lines already in Koha. (In reply to comment #1) > Created attachment 18181 [details] [review] [review] > Proposed patch > > Moved patch and bug description to a new bug. Thanks Katrin for correcting this bugfix :) Rafal, thx to you for fixing an annoying bug and welcome :) http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=3898e70fe55b9e56a474220223adcf205a12add1 |