Summary: | Search domains do not seem to work | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Searching | Assignee: | Jared Camins-Esakov <jcamins> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10281: searching for a search domain fails
Bug 10281: searching for a search domain fails Bug 10281: searching for a search domain fails [PASSED QA] Bug 10281: searching for a search domain fails |
Description
Magnus Enger
2013-05-18 11:32:13 UTC
Here are the errors I get when I limit to a group and get no results: OPAC, simple search: [Sat May 18 14:04:01 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:01 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkien&branch_group_limit=multibranchlimit-NARVIK [Sat May 18 14:04:01 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:01 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 39., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkien&branch_group_limit=multibranchlimit-NARVIK [Sat May 18 14:04:01 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:01 2013] opac-search.pl: WARNING: query problem with kw,wrdl,rtrn=tolkien and () ZOOM error 10014 "CCL parsing error" (addinfo: "Search word expected") from diag-set 'ZOOM' at /usr/share/koha/lib/C4/Search.pm line 378., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkien&branch_group_limit=multibranchlimit-NARVIK OPAC, advanced search: [Sat May 18 14:04:13 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:13 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkien&branch_group_limit=multibranchlimit-NARVIK [Sat May 18 14:04:13 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:13 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 39., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkien&branch_group_limit=multibranchlimit-NARVIK [Sat May 18 14:04:22 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:22 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl [Sat May 18 14:04:22 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:22 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 39., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl [Sat May 18 14:04:23 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:23 2013] opac-search.pl: WARNING: query problem with kw,wrdl,rtrn=tolkien and () ZOOM error 10014 "CCL parsing error" (addinfo: "Search word expected") from diag-set 'ZOOM' at /usr/share/koha/lib/C4/Search.pm line 378., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl Created attachment 18227 [details] [review] Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off Created attachment 18229 [details] [review] Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off Created attachment 18234 [details] [review] Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off Signed-off-by: Magnus Enger <magnus@enger.priv.no> I have failed to recreate the problem on three different dev installs, both on Ubuntu and Debian, but the current patch does not break anything as far as I can tell, so I'm signing off. I tested with two libraries in the same search domain, with each library owning a different book by the same author. Searching for the author in - all libraries, - individual libraries and - the search domain that contains both libraries all return the expected results. Created attachment 18236 [details] [review] [PASSED QA] Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off Signed-off-by: Magnus Enger <magnus@enger.priv.no> I have failed to recreate the problem on three different dev installs, both on Ubuntu and Debian, but the current patch does not break anything as far as I can tell, so I'm signing off. I tested with two libraries in the same search domain, with each library owning a different book by the same author. Searching for the author in - all libraries, - individual libraries and - the search domain that contains both libraries all return the expected results. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. I couldn't reproduce the problem, but didn't find any regressions. This patch has been pushed to master and 3.12.x. |