| Summary: | Error 500 in staff client displays old start page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> |
| Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, gmcharlt, jonathan.druart, mtompset, nick, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
500 error including old start page
Bug 10285: Remove links from the error pages [SIGNED OFF] Bug 10285: Remove links from the error pages [PASSED QA] Bug 10285: Remove links from the error pages |
||
I think this is okay. I don't think we want to display the full-styled home page as that might be confusing. I suspect, however, that we need to update the page to reflect changes since this was last updated. This is still valid for master. Maybe we should just show the message and remove all the links to the modules below? (In reply to Katrin Fischer from comment #2) > This is still valid for master. Maybe we should just show the message and > remove all the links to the modules below? +1 from me. :-) The relevant files are in koha-tmpl/intranet-tmpl/prog/en/modules/errors/ Created attachment 37821 [details] [review] Bug 10285: Remove links from the error pages The error page (400, 401, 402, 403, 404, 405 and 500) displays parts the old staff client main page. The user can easily browses using navigation links. Test plan: Go on the 400.pl, 401.pl, 402.pl, 403.pl, 404.pl, 405.pl and 500.pl pages, and confirm all is fine and you don't get the old style blocks. Created attachment 37939 [details] [review] [SIGNED OFF] Bug 10285: Remove links from the error pages The error page (400, 401, 402, 403, 404, 405 and 500) displays parts the old staff client main page. The user can easily browses using navigation links. Test plan: Go on the 400.pl, 401.pl, 402.pl, 403.pl, 404.pl, 405.pl and 500.pl pages, and confirm all is fine and you don't get the old style blocks. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed off, but worth noting, I didn't check 405.pl because I can't find it (In reply to Nick Clemens from comment #7) > Signed off, but worth noting, I didn't check 405.pl because I can't find it $ git grep 405.t | grep -v "\.po:" generates nothing. 405 can be removed? (In reply to Nick Clemens from comment #7) > Signed off, but worth noting, I didn't check 405.pl because I can't find it HTTP error code 405 is "Method Not Allowed" -- disable post and get in your apache config, and see what wonderful kabooms occur? Created attachment 38110 [details] [review] [PASSED QA] Bug 10285: Remove links from the error pages The error page (400, 401, 402, 403, 404, 405 and 500) displays parts the old staff client main page. The user can easily browses using navigation links. Test plan: Go on the 400.pl, 401.pl, 402.pl, 403.pl, 404.pl, 405.pl and 500.pl pages, and confirm all is fine and you don't get the old style blocks. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> http://bugs.koha-community.org/show_bug.cgi?id=10258 Patch pushed to master. Thanks Jonathan! String changes held for 3.18.7 Applied to 3.18.x will be in 3.18.7 |
Created attachment 18241 [details] 500 error including old start page If you trigger a 500 internal server error in the the saff client, the old start page is displayed along with the error message. See attached screenshot.