Summary: | authorities plugin putting values in reverse order | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Cataloging | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
authority plugin with reverse order
Bug 10299: authority plugin - authority field are reversed [SIGNED-OFF] Bug 10299: authority plugin - authority field are reversed Bug 10299: authority plugin - authority field are reversed |
This has gotten no attention is over a year - any ideas. Created attachment 37960 [details] [review] Bug 10299: authority plugin - authority field are reversed If you click the plugin next to an authority field that is already populated it takes the values from the field and puts them in the search in the reverse order. Test plan: 1/ Edit a biblio 2/ Fill the subfield for an authority field (for instance 650$v, 650$x, 650$y, etc.) 3/ Click on the authority plugin Before this patch, the values were concatenated in the reverse order. With this patch, it should not. Thanks for the image, very useful :) Created attachment 39199 [details] [review] [SIGNED-OFF] Bug 10299: authority plugin - authority field are reversed If you click the plugin next to an authority field that is already populated it takes the values from the field and puts them in the search in the reverse order. Test plan: 1/ Edit a biblio 2/ Fill the subfield for an authority field (for instance 650$v, 650$x, 650$y, etc.) 3/ Click on the authority plugin Before this patch, the values were concatenated in the reverse order. With this patch, it should not. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no koha-qa errors Created attachment 39293 [details] [review] Bug 10299: authority plugin - authority field are reversed If you click the plugin next to an authority field that is already populated it takes the values from the field and puts them in the search in the reverse order. Test plan: 1/ Edit a biblio 2/ Fill the subfield for an authority field (for instance 650$v, 650$x, 650$y, etc.) 3/ Click on the authority plugin Before this patch, the values were concatenated in the reverse order. With this patch, it should not. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no koha-qa errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Patch pushed to master. Thanks Jonathan! |
Created attachment 18269 [details] authority plugin with reverse order This is hard to explain, so please see the attached image. If you click the plugin next to an authority field that is already populated it takes the values from the field and puts them in the search in the reverse order. So in the image, the field has PA, Phila, Fiction but then when you click on the plugin it reorders them as Fiction, Phila, PA. The order should match. Nicole