Bug 10331

A looks good, but it seems something is wrong with my UNIMARC installation, as I am not able to add authorities there :(

No matter what I enter in 100$a I always get: Unsupported UNIMARC character encoding [] for XML output for UNIMARCAUTH; 100$a -> a at /usr/share/perl5/MARC/File/XML.pm line 505.

Jonathan, maybe you could take a look at this? Adding you as QA contact.

(In reply to Katrin Fischer from comment #5)
> A looks good, but it seems something is wrong with my UNIMARC installation,
> as I am not able to add authorities there :(
> 
> No matter what I enter in 100$a I always get: Unsupported UNIMARC character
> encoding [] for XML output for UNIMARCAUTH; 100$a -> a at
> /usr/share/perl5/MARC/File/XML.pm line 505.
> 
Katrin,
I used 'YYYYMMDDaengy01030204ba0' for 100a, just copied from UNIMARC auth manual, and worked

But I noticed something else unrelated with the bug. If I add a new authority and press save without filling any tag, the error message points the missing fields but the tab number information is missing, at last in my install. For example "fixed length control f in tab ..."

Could it be that the English frameworks are missing a plugin here? I would have never guessed that :) Trying again a little later - thx Bernardo!

Working on this again now - Bernardo, could you file a new bug for the error messages?

Created attachment 20877 [details] [review]
[PASSED QA] Bug 10331 - Little errors in unimarc_field_4XX.pl (punctuation)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Work as described, no koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Copying the test plan from the bug report:

A.
1) have $a active in one of the linking fields (like 461, 463, etc.).
2) have a biblio record with the field 700 $a, $b, $f filled up
3) go to cataloguing -> field 4XX of your choice, use the plugin to
  fetch data from biblio rec. mentioned in 2)
4) see the punctuation in $a -- it will be wrong (no closing bracket)

B.
1) have $a active in one of the linking fields (like 461, 463, etc.).
2) have a biblio record with the field 700 $a, $b, $c, $f filled up
3) go to cataloguing -> field 4XX of your choice, use the plugin to
   fetch data from biblio rec. mentioned in 2)
4) see the punctuation in $a -- it will be wrong (dash instead of
   semicolon between original $c and $f, no closing bracket)

C.
1) have $a active in one of the linking fields (like 461, 463, etc.).
2) have a biblio record with the field 702 $a, $b, $c filled up
3) go to cataloguing -> field 4XX of your choice, use the plugin to
   fetch data from biblio rec. mentioned in 2)
4) see the punctuation in $a -- it will be wrong (unnecessary semicolon
   after original $c, n.b. lacking space).

D.
1) have $a active in one of the linking fields (like 461, 463, etc.).
2) have a biblio record with the field 712 $a, $b filled up
3) go to cataloguing -> field 4XX of your choice, use the plugin to
   fetch data from biblio rec. mentioned in b)
4) see the punctuation in $a -- it will be wrong (unnecessary opening
   bracket at the end).

Test plan, all tests and QA script pass.
Thx Bernardo for his testing and explanations!

I have worked on this by using the provided test plan. I am dding some UNIMARC users in CC - Jonathan, Mathieu, please add your comment, if you think this needs more testing. 
The punctuation looked nice and sane to me - but who knows :)

We don't really use cataloguing modyule in Rennes 2 (all records imported from Academic libraries catalog), so I won't test. But I am sure your tests are fine.

Mathieu

Pushed to master.  Thanks, Janusz!

This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Janusz!

This patch has been pushed to 3.8.x, and will be in 3.08.20.

Thanks Janusz!