Summary: | Copy number should be incremented when adding multiple items at once | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Cataloging | Assignee: | Björn Nylén <bjorn.nylen> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | bjorn.nylen, frank.hansen, jason.oneil, lucas, m.de.rooy, marjorie.barry-vila, martin.renvoize, nick, pierre-marc.thibault |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.05
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 22647 | ||
Attachments: |
Bug 10345: Increment copy number when adding multiple copies.
Bug 10345: Increment copy number when adding multiple copies. Bug 10345: Increment copy number when adding multiple copies. |
Description
Katrin Fischer
2013-05-27 12:27:33 UTC
Hi I'm happy to have a look at this bug as it's frustrating one of our librarians no-end. I'm a developer, though not particularly familiar with the Koha codebase (I have done a few custom patches before, but not submitted anything back for inclusion). Is there a specific process to follow here, or a regular contributor happy to help me out, or should I just try fix it on my own and then submit a patch? Thanks! Jason Hi Jason, if you can upload a patch and change the status to "Needs sign-off" that would be great. There is some information about the workflow on the wiki: http://wiki.koha-community.org/wiki/Development_workflow#Steps Let us know if we can help. This issue came up at the swedish Koha users hackfest so we made a patch. Will try to submit it shortly. Created attachment 87153 [details] [review] Bug 10345: Increment copy number when adding multiple copies. To test: 1. Add multiple copies of an item with data in the 'Copy number' field. Note that tha data will be identical for all items. 2. Apply patch. 3. Add multiple copies of an item with a positive integer (ie. only digits) in the 'Copy number' field. Note that the copy number is incremented for each item. 4. Add multiple copies of an item with some other type of data in the 'Copy number' field. Note that the copy number field remains unchanged for the added items. Created attachment 87237 [details] [review] Bug 10345: Increment copy number when adding multiple copies. To test: 1. Add multiple copies of an item with data in the 'Copy number' field. Note that tha data will be identical for all items. 2. Apply patch. 3. Add multiple copies of an item with a positive integer (ie. only digits) in the 'Copy number' field. Note that the copy number is incremented for each item. 4. Add multiple copies of an item with some other type of data in the 'Copy number' field. Note that the copy number field remains unchanged for the added items. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Created attachment 87353 [details] [review] Bug 10345: Increment copy number when adding multiple copies. To test: 1. Add multiple copies of an item with data in the 'Copy number' field. Note that tha data will be identical for all items. 2. Apply patch. 3. Add multiple copies of an item with a positive integer (ie. only digits) in the 'Copy number' field. Note that the copy number is incremented for each item. 4. Add multiple copies of an item with some other type of data in the 'Copy number' field. Note that the copy number field remains unchanged for the added items. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx Björn for taking care of such an 'oldie' Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 backported to 18.05.x for 18.05.12 |