Summary: | acq edited items showing 'null's | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
edited item says null
Bug 10388: Does not display 'null' after editing an item on receiving Bug 10388: Does not display 'null' after editing an item on receiving [PASSED QA] Bug 10388: Does not display 'null' after editing an item on receiving |
Just a note that this bug goes back quite far - I have encountered it in 3.10.2 recently. This is still valid. Created attachment 37550 [details] [review] Bug 10388: Does not display 'null' after editing an item on receiving After editing an item on receiving, 'null' is displayed if no value is defined for a field. It should be blank. Test plan: 0/ Set AcqCreateItem to 'ordering' 1/ Go on the receipt page page 2/ Edit an item 3/ Does not fill all values 4/ Confirm that undefined values are replaced with an empty string Created attachment 37672 [details] [review] Bug 10388: Does not display 'null' after editing an item on receiving After editing an item on receiving, 'null' is displayed if no value is defined for a field. It should be blank. Test plan: 0/ Set AcqCreateItem to 'ordering' 1/ Go on the receipt page page 2/ Edit an item 3/ Does not fill all values 4/ Confirm that undefined values are replaced with an empty string NOTE: I think you meant receive. Editing requires at least clicking the dropdown value, even if you don't change it before clicking save. null's appeared. Post patch application was able to get nulls to disappear. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 38152 [details] [review] [PASSED QA] Bug 10388: Does not display 'null' after editing an item on receiving After editing an item on receiving, 'null' is displayed if no value is defined for a field. It should be blank. Test plan: 0/ Set AcqCreateItem to 'ordering' 1/ Go on the receipt page page 2/ Edit an item 3/ Does not fill all values 4/ Confirm that undefined values are replaced with an empty string NOTE: I think you meant receive. Editing requires at least clicking the dropdown value, even if you don't change it before clicking save. null's appeared. Post patch application was able to get nulls to disappear. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> One question I won't have to answer in training again :) yay! Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.7 |
Created attachment 18567 [details] edited item says null When editing items on the receipt page in acquisitions you see 'null' in all fields that have no value. This used to be a blank - or clear column, but now in 3.10.x and 3.12 and master it's showing null. It should be blank instead.