Summary: | Remove obsolete CSS related to YUI autocomplete | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, srdjan, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10406 - Remove obsolete CSS related to YUI autocomplete
[SIGNED-OFF] Bug 10406 - Remove obsolete CSS related to YUI autocomplete Bug 10406 - Remove obsolete CSS related to YUI autocomplete Bug 10406 - (followup) YUI-ac related code [SIGNED-OFF] Bug 10406 - (followup) YUI-ac related code Bug 10406 - (followup) YUI-ac related code |
Description
Owen Leonard
2013-06-04 17:19:58 UTC
Created attachment 18644 [details] [review] Bug 10406 - Remove obsolete CSS related to YUI autocomplete staff-global.css contains CSS which related to the old YUI autocomplete widget. Since this has been replaced with jQueryUI the CSS is now unused and can be removed. To test, apply the patch and confirm that autocomplete looks correct and works correctly in the global circulation search box (with CircAutocompl enabled) and in the overdues report when entering a value into the filter form in a patron attribute field which is linked to an authorized value. Created attachment 18689 [details] [review] [SIGNED-OFF] Bug 10406 - Remove obsolete CSS related to YUI autocomplete staff-global.css contains CSS which related to the old YUI autocomplete widget. Since this has been replaced with jQueryUI the CSS is now unused and can be removed. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Created attachment 18815 [details] [review] Bug 10406 - Remove obsolete CSS related to YUI autocomplete staff-global.css contains CSS which related to the old YUI autocomplete widget. Since this has been replaced with jQueryUI the CSS is now unused and can be removed. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master. Thanks, Owen! Created attachment 18855 [details] [review] Bug 10406 - (followup) YUI-ac related code Some other stuff that might be removed. To test: - Apply, the search form doesn't break. Sponsored-by: Universidad Nacional de Córdoba This patch has been pushed to 3.12.x, will be in 3.12.1. This patch fixes an annoying cosmetic bug on ifrefox due to the width of the borrowerautocomplete div being fixed to 500px (50px more than what was calculated for the other input tabs). Well done Owen! 3.12.x will look prettier! I provided a follow-up for some other stuff left around. Created attachment 18856 [details] [review] [SIGNED-OFF] Bug 10406 - (followup) YUI-ac related code Some other stuff that might be removed. To test: - Apply, the search form doesn't break. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 18898 [details] [review] Bug 10406 - (followup) YUI-ac related code Some other stuff that might be removed. To test: - Apply, the search form doesn't break. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed the follow-up (with rewording of the commit message) to master. Thanks, Tomás! This patch has been pushed to 3.12.x, will be in 3.12.1. |