Summary: | updating child to adult loses password | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | critical | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, mtompset, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 10453: Updating child to adult loses password
[SIGNED OFF] Bug 10453: Updating child to adult loses password [PASSED QA] Bug 10453: Updating child to adult loses password |
Description
Nicole C. Engard
2013-06-12 14:40:22 UTC
Created attachment 23809 [details] [review] Bug 10453: Updating child to adult loses password ModMember supposes the password given in parameter is the password string, so if it receives the encrypted password, it will encrypt it again! Test plan: 1/ Create or choose a child patron 2/ Update it to an adult category using the "Update child to adult patron" link 3/ Try to log in at the OPAC with this patron: It is not possible, the password has changed 4/ Apply the patch and try again previous steps Created attachment 23810 [details] [review] [SIGNED OFF] Bug 10453: Updating child to adult loses password ModMember supposes the password given in parameter is the password string, so if it receives the encrypted password, it will encrypt it again! By simply deleting the password key from the hash, ModMember leaves the password unchanged. Test plan: 1/ Create or choose a child patron 2/ Update it to an adult category using the "Update child to adult patron" link 3/ Try to log in at the OPAC with this patron: It is not possible, the password has changed 4/ Apply the patch and try again previous steps Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Merry Christmas! :) Created attachment 23818 [details] [review] [PASSED QA] Bug 10453: Updating child to adult loses password ModMember supposes the password given in parameter is the password string, so if it receives the encrypted password, it will encrypt it again! By simply deleting the password key from the hash, ModMember leaves the password unchanged. Test plan: 1/ Create or choose a child patron 2/ Update it to an adult category using the "Update child to adult patron" link 3/ Try to log in at the OPAC with this patron: It is not possible, the password has changed 4/ Apply the patch and try again previous steps Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Confirmed the problem and tested the patch fixes it. Passes all tests and QA script. Pushed to master. Thanks, Jonathan! Patch pushed to 3.14.x, will be in 3.14.2. This patch has been pushed to 3.12.x, will be in 3.12.11. Thanks Jonathan! |