Summary: | Reference to fields 780 and 785 in UNIMARC XSLT should be removed | ||
---|---|---|---|
Product: | Koha | Reporter: | Mathieu Saby <mathsabypro> |
Component: | Templates | Assignee: | Mathieu Saby <mathsabypro> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | trivial | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 11246 | ||
Attachments: |
Bug 10465 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files
[SIGNED-OFF] Bug 10465 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files [PASSED QA] Bug 10465 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files |
Description
Mathieu Saby
2013-06-13 17:11:28 UTC
Created attachment 20883 [details] [review] Bug 10465 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files UNIMARCslim2OPACDetail.xsl and UNIMARCslim2intranetDetail.xsl contains references to 780 and 785 fields, that exist in Marc21 but not in UNIMARC. This patch remove the code related to 780 and 785 fields. No effect should be visible. To test : in a UNIMARC Koha 1. be sure that OPACXSLTDetailsDisplay , OPACXSLTResultsDisplay , XSLTDetailsDisplay and XSLTResultsDisplay sysprefs are set to "default" 2. apply the patch 3. search some records in staff interface : the list view and the detail view must be exacty the same as before you apply the patch. 4. search some records in OPAC : the list view and the detail view must be exacty the same as before you apply the patch. M. Saby Created attachment 21151 [details] [review] [SIGNED-OFF] Bug 10465 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files UNIMARCslim2OPACDetail.xsl and UNIMARCslim2intranetDetail.xsl contains references to 780 and 785 fields, that exist in Marc21 but not in UNIMARC. This patch remove the code related to 780 and 785 fields. No effect should be visible. To test : in a UNIMARC Koha 1. be sure that OPACXSLTDetailsDisplay , OPACXSLTResultsDisplay , XSLTDetailsDisplay and XSLTResultsDisplay sysprefs are set to "default" 2. apply the patch 3. search some records in staff interface : the list view and the detail view must be exacty the same as before you apply the patch. 4. search some records in OPAC : the list view and the detail view must be exacty the same as before you apply the patch. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: No diplay change, no koha-qa errors. Removes what can't be displayed. Created attachment 21310 [details] [review] [PASSED QA] Bug 10465 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files UNIMARCslim2OPACDetail.xsl and UNIMARCslim2intranetDetail.xsl contains references to 780 and 785 fields, that exist in Marc21 but not in UNIMARC. This patch remove the code related to 780 and 785 fields. No effect should be visible. To test : in a UNIMARC Koha 1. be sure that OPACXSLTDetailsDisplay , OPACXSLTResultsDisplay , XSLTDetailsDisplay and XSLTResultsDisplay sysprefs are set to "default" 2. apply the patch 3. search some records in staff interface : the list view and the detail view must be exacty the same as before you apply the patch. 4. search some records in OPAC : the list view and the detail view must be exacty the same as before you apply the patch. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: No diplay change, no koha-qa errors. Removes what can't be displayed. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked detail pages in OPAC and intranet still display correctly and without errors. Pushed to master. Thanks, Mathieu! I note that it looks like the equivalent of the MARC21 780/785 in UNIMARC is a bunch of 4XX fields, for anybody who wants to implement preceding/succeeding links correctly in the UNIMARC XSLT templates. Thanks. I thought it was made but I will test it. We use our own XSLT so we did not noticed the bugs of the standard one... Mathieu Same changes must be made in new bootstrap opac theme. Mathieu This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Mathieu! And I need to port it to boostrap theme. Homework for this evening... Mathieu |