Summary: | Add pending holds to summary print | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Patrons | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aleisha, gmcharlt, gwilliams, hector.hecaxmmx, jweaver, kyle.m.hall, marjorie.barry-vila, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 10468: Adding holds table to summary print
Bug 10468: Fix for qa tools Bug 10468: Adding holds table to summary print [PASSED QA] Bug 10468: Adding holds table to summary print |
Description
Nicole C. Engard
2013-06-14 12:14:32 UTC
In version 3.21 of Koha, print summary shows checkouts and outstanding fines but not holds, so will work out how to put this in. Created attachment 41689 [details] [review] Bug 10468: Adding holds table to summary print To test: 1) Add a hold to a patron 2) Go to patron page 3) Click Print Summary 4) Confirm that 'Pending Holds' table displays with correct information under appropriate headings (should be Title, Author, Placed on (reserve date), Expires on (expiration date), and Pick up library) Patch works as expected but qa tools complain about forbidden patterns: FAIL members/summary-print.pl FAIL forbidden patterns forbidden pattern: tab char (line 131) forbidden pattern: trailing space char (line 138) forbidden pattern: tab char (line 130) forbidden pattern: tab char (line 134) forbidden pattern: tab char (line 133) forbidden pattern: trailing space char (line 135) forbidden pattern: trailing space char (line 137) forbidden pattern: trailing space char (line 140) forbidden pattern: tab char (line 132) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt FAIL forbidden patterns forbidden pattern: tab char (line 90) Created attachment 42133 [details] [review] Bug 10468: Fix for qa tools Hopefully this gets rid of those complaints! Created attachment 45217 [details] [review] Bug 10468: Adding holds table to summary print To test: 1) Add a hold to a patron 2) Go to patron page 3) Click Print Summary 4) Confirm that 'Pending Holds' table displays with correct information under appropriate headings (should be Title, Author, Placed on (reserve date), Expires on (expiration date), and Pick up library) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised (In reply to Aleisha Amohia from comment #4) > Created attachment 42133 [details] [review] [review] > Bug 10468: Fix for qa tools > > Hopefully this gets rid of those complaints! Hi Aleisha I squashed the two patches and I've signed-off also patches did not apply due the changes introduced by Bug 15068, but i fixed it up. Regards Created attachment 45250 [details] [review] [PASSED QA] Bug 10468: Adding holds table to summary print To test: 1) Add a hold to a patron 2) Go to patron page 3) Click Print Summary 4) Confirm that 'Pending Holds' table displays with correct information under appropriate headings (should be Title, Author, Placed on (reserve date), Expires on (expiration date), and Pick up library) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master. Fixed a bit of inconsistent indentation, please take note for the future. Thanks for your contribution! |