Summary: | add items limit and sort to rebuild zebra | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Searching | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED INVALID | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, gitbot, koha.aixmarseille |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 |
||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 7986 | ||
Bug Blocks: | |||
Attachments: | Proposed patch |
Description
Fridolin Somers
2013-06-17 13:48:13 UTC
Created attachment 19073 [details] [review] Proposed patch See commit message Patch applied cleanly, go forth and signoff Patch applied cleanly, go forth and signoff Bug 11096 should take care of the record size problem. As for limiting the number of items...I'm not sure that an arbitrary cut off is the best idea, as it will lead to unexpected/unpredictable results. Off the top of my head, it should also create problems with search. The barcode (i.e. "bc") and call number indexes being the ones that spring immediately to mind. I haven't put too much thought into it at this point, but...this patch seems like it would introduce a lot of (sometimes silent) problems. (In reply to David Cook from comment #4) > Bug 11096 should take care of the record size problem. Indeed. But this is only an indexing option, not mandatory to use. It is made to cut off if there is a huge number of items, like more than 100. It corrects a problem and makes indexing faster. So why not adding it ? In the end, I agree, no need to have more options and the risk off misunderstand is real. Thanks for your help. |