Bug 10484

Summary: serials-edit.pl not checking for barcode field before checking for barcode subfield
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: SerialsAssignee: Kyle M Hall (khall) <kyle>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: bgkriegel, chrish, colin.campbell, gmcharlt, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 10484 - serials-edit.pl not checking for barcode field before checking for barcode subfield
Bug 10484 - serials-edit.pl not checking for barcode field before checking for barcode subfield
[PASSED QA] Bug 10484 - serials-edit.pl not checking for barcode field before checking for barcode subfield

Description Kyle M Hall (khall) 2013-06-17 16:28:04 UTC
The script serials-edit.pl is not checking for the existence of the barcode field before checking for barcode subfield for autoBarcode = incremental. If the barcode field doesn't exist, the script dies with errors.
Comment 1 Kyle M Hall (khall) 2013-06-17 16:28:39 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-06-23 07:12:48 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-06-30 19:50:05 UTC
Created attachment 19304 [details] [review]
[PASSED QA] Bug 10484 - serials-edit.pl not checking for barcode field before checking for barcode subfield

The script serials-edit.pl is not checking for the existence of the
barcode field before checking for barcode subfield for autoBarcode =
incremental. If the barcode field doesn't exist, the script dies with
errors.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script.
Checked that adding items on serial receive still works.
Comment 4 Galen Charlton 2013-07-01 02:03:11 UTC
Pushed to master.  Thanks, Kyle!
Comment 5 Tomás Cohen Arazi (tcohen) 2013-07-15 18:11:12 UTC
This patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Kyle!
Comment 6 Bernardo Gonzalez Kriegel 2013-08-02 20:20:45 UTC
Pushed to 3.10.x, will be in 3.10.10
Comment 7 Chris Hall 2013-08-17 23:03:50 UTC
Pushed to 3.8.x, will be in 3.8.17