Bug 10487

Summary: UT: GetMaxPickupDate needs unit tests.
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: BLOCKED --- QA Contact:
Severity: enhancement    
Priority: P5 - low CC: chris, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 8367, 10289    
Bug Blocks:    
Attachments: Bug 10487: UT: GetMaxPickupDate needs unit tests
Bug 10487: UT: GetMaxPickupDate needs unit tests
Bug 10487: UT: GetMaxPickupDate needs unit tests

Description Jonathan Druart 2013-06-18 09:55:20 UTC
GetMaxPickupDate is introduced by bug 8367. It needs unit tests.
Comment 1 Jonathan Druart 2013-06-18 09:58:56 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-06-21 12:56:50 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2013-08-05 22:53:12 UTC
Conflicts now
Comment 4 Jonathan Druart 2013-08-14 14:59:25 UTC
Created attachment 20339 [details] [review]
Bug 10487: UT: GetMaxPickupDate needs unit tests

GetMaxPickupDate is introduced by bug 8367. It needs unit tests.

$ prove t/db_dependent/Reserves.t
should produce:
 t/db_dependent/Reserves.t .. 1/14 #
 # Creating biblio instance for testing.
 # Creating item instance for testing.
 ERROR: GetMaxPickupDate is called without reserve and without itemnumber
 ERROR: GetMaxPickupDate is called without reserve and without itemnumber
 t/db_dependent/Reserves.t .. 11/14 # Deleting item testing instance.
 # Deleting biblio testing instance.
 # Deleting borrower.
 t/db_dependent/Reserves.t .. ok
 All tests successful.
 Files=1, Tests=14,  1 wallclock secs ( 0.03 usr  0.00 sys +  0.42 cusr
 0.06 csys =  0.51 CPU)
 Result: PASS

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Marcel de Rooy 2013-09-23 06:00:29 UTC
Bug 8367 does not apply. Moving this one to Blocked for that reason..