|
Description
Kyle M Hall (khall)
2013-06-19 14:39:11 UTC
Created attachment 19155 [details] [review] Bug 10493 - Add renewal script Koha needs a renewal tool that functions similar to the returns where a librarian can continuously scan items for renewal. This script should block renewals that are impossible, and allow the same renewal overrides as circulation.pl Test plan: 1) Apply the patches for bug 8798 2) Apply this patch 3) Browse to /cgi-bin/koha/circ/renew.pl 4) Enter an invalid barcode, you should get an error message 5) Enter a valid, but not checked out barcode, you should get an error message. 6) Enter a valid barcode that is checkout out and should be renewable, you should get a success message. 7) Enable AllowRenewalLimitOverride 8) Enter a barcode for an item that has been renewed too many times 9) You should get a warning which you can override. 10) Disable AllowRenewalLimitOverride 11) Repeat steap 8 12) You should get a blocking error message 11) Enter a barcode for an item with unfilled holds on it, you should get an overridable warning Created attachment 20044 [details] [review] Bug 10493 - Add renewal script Koha needs a renewal tool that functions similar to the returns where a librarian can continuously scan items for renewal. This script should block renewals that are impossible, and allow the same renewal overrides as circulation.pl Test plan: 1) Apply the patches for bug 8798 2) Apply this patch 3) Browse to /cgi-bin/koha/circ/renew.pl 4) Enter an invalid barcode, you should get an error message 5) Enter a valid, but not checked out barcode, you should get an error message. 6) Enter a valid barcode that is checkout out and should be renewable, you should get a success message. 7) Enable AllowRenewalLimitOverride 8) Enter a barcode for an item that has been renewed too many times 9) You should get a warning which you can override. 10) Disable AllowRenewalLimitOverride 11) Repeat steap 8 12) You should get a blocking error message 11) Enter a barcode for an item with unfilled holds on it, you should get an overridable warning I, Heather Braum, from NEKLS sign off on this patch. We have tested it and it works. I would like to test this too but it doesn't apply. Applying: Bug 10493 - Add renewal script Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... CONFLICT (modify/delete): Koha/Schema/Result/Item.pm deleted in HEAD and modified in Bug 10493 - Add renewal script. Version Bug 10493 - Add renewal script of Koha/Schema/Result/Item.pm left in tree. CONFLICT (modify/delete): Koha/Schema/Result/Issue.pm deleted in HEAD and modified in Bug 10493 - Add renewal script. Version Bug 10493 - Add renewal script of Koha/Schema/Result/Issue.pm left in tree. Failed to merge in the changes. Oh sorry, probably the dependency, which I missed. Created attachment 20049 [details] [review] [SIGNED-OFF] Bug 10493 - Add renewal script Koha needs a renewal tool that functions similar to the returns where a librarian can continuously scan items for renewal. This script should block renewals that are impossible, and allow the same renewal overrides as circulation.pl Test plan: 1) Apply the patches for bug 8798 2) Apply this patch 3) Browse to /cgi-bin/koha/circ/renew.pl 4) Enter an invalid barcode, you should get an error message 5) Enter a valid, but not checked out barcode, you should get an error message. 6) Enter a valid barcode that is checkout out and should be renewable, you should get a success message. 7) Enable AllowRenewalLimitOverride 8) Enter a barcode for an item that has been renewed too many times 9) You should get a warning which you can override. 10) Disable AllowRenewalLimitOverride 11) Repeat steap 8 12) You should get a blocking error message 11) Enter a barcode for an item with unfilled holds on it, you should get an overridable warning Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 20050 [details] [review] Bug 10493 [Template follow-up] Add renewal script This template followup fixes some minor template errors and adds some style to dialog buttons matching those seen on the circulation page. To test, submit barcodes to trigger the various error conditions: Non-existant barcode, over the renew limit, restricted patron, item on hold. Override and Ignore buttons should be properly styled and functional. Created attachment 20143 [details] [review] Bug 10493 [Template follow-up] Add renewal script This template followup fixes some minor template errors and adds some style to dialog buttons matching those seen on the circulation page. To test, submit barcodes to trigger the various error conditions: Non-existant barcode, over the renew limit, restricted patron, item on hold. Override and Ignore buttons should be properly styled and functional. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> *** Bug 7632 has been marked as a duplicate of this bug. *** Created attachment 22076 [details] [review] Bug 10493 - Add renewal script Koha needs a renewal tool that functions similar to the returns where a librarian can continuously scan items for renewal. This script should block renewals that are impossible, and allow the same renewal overrides as circulation.pl Test plan: 1) Apply the patches for bug 8798 2) Apply this patch 3) Browse to /cgi-bin/koha/circ/renew.pl 4) Enter an invalid barcode, you should get an error message 5) Enter a valid, but not checked out barcode, you should get an error message. 6) Enter a valid barcode that is checkout out and should be renewable, you should get a success message. 7) Enable AllowRenewalLimitOverride 8) Enter a barcode for an item that has been renewed too many times 9) You should get a warning which you can override. 10) Disable AllowRenewalLimitOverride 11) Repeat steap 8 12) You should get a blocking error message 11) Enter a barcode for an item with unfilled holds on it, you should get an overridable warning Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 22077 [details] [review] Bug 10493 [Template follow-up] Add renewal script This template followup fixes some minor template errors and adds some style to dialog buttons matching those seen on the circulation page. To test, submit barcodes to trigger the various error conditions: Non-existant barcode, over the renew limit, restricted patron, item on hold. Override and Ignore buttons should be properly styled and functional. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Hi Kyle, 2 small things: Can you please take a look at the GPL version for renew.pl and see if you can update it to GPL3? Also: You are using the KohaBranchName plugin and I think we are going to standardize to use Branches instead (see bug 10626. -[% USE KohaBranchName %] +[% USE Branches %] So could you switch it please? Continuing testing, as both things are small and easy to check in a follow up later. Hi Kyle, another thing: when I renew an item where the title has an umlaut (Ex. Die Räuber), the umlaut is not shown right in the "can't renew" message. Please fix and switch back to signed off. Thx! Created attachment 22139 [details] [review] Bug 10493 [QA follow-up] Add renewal script Created attachment 22180 [details] [review] Bug 10493 [QA follow-up] Add renewal script Created attachment 22192 [details] [review] Bug 10493 [QA follow-up] Add renewal script Created attachment 22194 [details] [review] Bug 10493 [QA follow-up] Add renewal script Created attachment 22196 [details] [review] Bug 10493 [QA follow-up] Add renewal script Created attachment 22197 [details] [review] Bug 10493 [QA follow-up] Add renewal script Created attachment 22199 [details] [review] Bug 10493 [QA follow-up] Add renewal script Created attachment 22200 [details] [review] Bug 10493 [QA follow-up] Add renewal script Adds the new JavaScript function removeFocus() to staff-global.js Use this function to remove the focus from any element for repeated scanning actions on errors so the librarian doesn't continue scanning and miss the error. Created attachment 22202 [details] [review] Bug 10493 [QA follow-up] Add renewal script Adds a new Template Toolkit filter EncodeUTF8 to encode strings to utf8 for correct display of diactritics. Adds the new JavaScript function removeFocus() to staff-global.js Use this function to remove the focus from any element for repeated scanning actions on errors so the librarian doesn't continue scanning and miss the error. Created attachment 22203 [details] [review] Bug 10493 [QA follow-up] Add renewal script Adds a new Template Toolkit filter EncodeUTF8 to encode strings to utf8 for correct display of diactritics. Adds the new JavaScript function removeFocus() to staff-global.js Use this function to remove the focus from any element for repeated scanning actions on errors so the librarian doesn't continue scanning and miss the error. Created attachment 22241 [details] [review] [PASSED QA] Bug 10493 - Add renewal script Koha needs a renewal tool that functions similar to the returns where a librarian can continuously scan items for renewal. This script should block renewals that are impossible, and allow the same renewal overrides as circulation.pl Test plan: 1) Apply the patches for bug 8798 2) Apply this patch 3) Browse to /cgi-bin/koha/circ/renew.pl 4) Enter an invalid barcode, you should get an error message 5) Enter a valid, but not checked out barcode, you should get an error message. 6) Enter a valid barcode that is checkout out and should be renewable, you should get a success message. 7) Enable AllowRenewalLimitOverride 8) Enter a barcode for an item that has been renewed too many times 9) You should get a warning which you can override. 10) Disable AllowRenewalLimitOverride 11) Repeat steap 8 12) You should get a blocking error message 11) Enter a barcode for an item with unfilled holds on it, you should get an overridable warning Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Passes all tests and QA script, some issues have been addressed in follow-ups. Created attachment 22242 [details] [review] [PASSED QA] Bug 10493 [Template follow-up] Add renewal script This template followup fixes some minor template errors and adds some style to dialog buttons matching those seen on the circulation page. To test, submit barcodes to trigger the various error conditions: Non-existant barcode, over the renew limit, restricted patron, item on hold. Override and Ignore buttons should be properly styled and functional. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 22243 [details] [review] [PASSED QA] Bug 10493 [QA follow-up] Add renewal script Adds a new Template Toolkit filter EncodeUTF8 to encode strings to utf8 for correct display of diactritics. Adds the new JavaScript function removeFocus() to staff-global.js Use this function to remove the focus from any element for repeated scanning actions on errors so the librarian doesn't continue scanning and miss the error. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> This works as described - you have to actually look at the error and pick what you want to do or confirm it. I think maybe tying the action to a shortcut (c = confirm or similar) would be nice, so you can get away with only using the keyboard. Pushed to master. Thanks, Kyle! |