| Summary: | Add independent branches option for sql reports | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Reports | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aurelie.fichot, gitbot, jsasse, melissa, srdjan |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 10263 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 10502 - Add independent branches option for sql reports
Bug 10502 - Add independent branches option for sql reports Bug 10502 - Add independent branches option for sql reports Bug 10502 - Add independent branches option for sql reports Bug 10502 - Add independent branches option for sql reports Bug 10502 - Add independent branches option for sql reports |
||
|
Description
Kyle M Hall (khall)
2013-06-24 13:41:54 UTC
Created attachment 19217 [details] [review] Bug 10502 - Add independent branches option for sql reports This patch adds the ability to hide reports created by other libraries based on the new IndependentBranchesReports system preference. This is accomplished by adding a branchcode field to the sql reports, which is set on report creation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranchesReports 4) Log in with a non-superlibrarian staff account 5) View existing sql reports, you should see no difference. Existing reports are 'grandfathered' in, assuming that existing reports may be used by multiple libraries or library groups. 6) Ensure you have selected a library to act as via the "set library" link. 7) Create a new sql report. 8) Verify it was created and you can view and edit it. 9) Change the logged in library to a difference branch. 10) Observe that the report is no longer visible in the reports list. Test on sandbox Something went wrong ! Applying: Bug 10502 - Add independent branches option for sql reports Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10502 - Add independent branches option for sql reports When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 10502 - Add independent branches option for sql reports Bug 10502 - Add independent branches option for sql reports Apply? [yn] Patch left in /tmp/Bug-10502---Add-independent-branches-option-for-sq-SSLNId.patch === translation installation === Odd, I had no problems applying this patch to the latest master. Is this just "I don't want to see other branches reports, I cannot find mine" case, or "We don't want you to see what other people are doing" kind of thing? Cause if it is former, it should really be a select drop down, rather than a syspref. Maybe. It is a case of the latter. The idea is to create "walled gardens" for each library or group of libraries. We could definitely add a dropdown filter as a separate bug/patch, but that alone wouldn't satisfy the requirements for this bug. The intent of all these new independent branches patches is to make Koha more consortia friendly. Some consortia are rabid about not being able to see each others data, including even seeing each others reports! (In reply to Srdjan Jankovic from comment #4) > Is this just "I don't want to see other branches reports, I cannot find > mine" case, or "We don't want you to see what other people are doing" kind > of thing? Cause if it is former, it should really be a select drop down, > rather than a syspref. Maybe. fatal: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). Created attachment 20767 [details] [review] Bug 10502 - Add independent branches option for sql reports This patch adds the ability to hide reports created by other libraries based on the new IndependentBranchesReports system preference. This is accomplished by adding a branchcode field to the sql reports, which is set on report creation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranchesReports 4) Log in with a non-superlibrarian staff account 5) View existing sql reports, you should see no difference. Existing reports are 'grandfathered' in, assuming that existing reports may be used by multiple libraries or library groups. 6) Ensure you have selected a library to act as via the "set library" link. 7) Create a new sql report. 8) Verify it was created and you can view and edit it. 9) Change the logged in library to a difference branch. 10) Observe that the report is no longer visible in the reports list. Undefined subroutine &C4::Branch::GetIndependentGroupModificationRights called at /home/srdjan/koha/dev/C4/Reports/Guided.pm line 676. Did you apply the patch for 10276 first? That subroutine is contain in that bug's patch. Kyle (In reply to Srdjan Jankovic from comment #8) > Undefined subroutine &C4::Branch::GetIndependentGroupModificationRights > called at /home/srdjan/koha/dev/C4/Reports/Guided.pm line 676. Sorry, didn't Created attachment 21148 [details] [review] Bug 10502 - Add independent branches option for sql reports This patch adds the ability to hide reports created by other libraries based on the new IndependentBranchesReports system preference. This is accomplished by adding a branchcode field to the sql reports, which is set on report creation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranchesReports 4) Log in with a non-superlibrarian staff account 5) View existing sql reports, you should see no difference. Existing reports are 'grandfathered' in, assuming that existing reports may be used by multiple libraries or library groups. 6) Ensure you have selected a library to act as via the "set library" link. 7) Create a new sql report. 8) Verify it was created and you can view and edit it. 9) Change the logged in library to a difference branch. 10) Observe that the report is no longer visible in the reports list. Applying: Bug 10502 - Add independent branches option for sql reports Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10502 - Add independent branches option for sql reports The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Created attachment 23486 [details] [review] Bug 10502 - Add independent branches option for sql reports This patch adds the ability to hide reports created by other libraries based on the new IndependentBranchesReports system preference. This is accomplished by adding a branchcode field to the sql reports, which is set on report creation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranchesReports 4) Log in with a non-superlibrarian staff account 5) View existing sql reports, you should see no difference. Existing reports are 'grandfathered' in, assuming that existing reports may be used by multiple libraries or library groups. 6) Ensure you have selected a library to act as via the "set library" link. 7) Create a new sql report. 8) Verify it was created and you can view and edit it. 9) Change the logged in library to a difference branch. 10) Observe that the report is no longer visible in the reports list. Created attachment 23492 [details] [review] Bug 10502 - Add independent branches option for sql reports This patch adds the ability to hide reports created by other libraries based on the new IndependentBranchesReports system preference. This is accomplished by adding a branchcode field to the sql reports, which is set on report creation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranchesReports 4) Log in with a non-superlibrarian staff account 5) View existing sql reports, you should see no difference. Existing reports are 'grandfathered' in, assuming that existing reports may be used by multiple libraries or library groups. 6) Ensure you have selected a library to act as via the "set library" link. 7) Create a new sql report. 8) Verify it was created and you can view and edit it. 9) Change the logged in library to a difference branch. 10) Observe that the report is no longer visible in the reports list. I tested this and want to sign off on it. Joel Sasse Created attachment 23640 [details] [review] Bug 10502 - Add independent branches option for sql reports Couldn't spot any problems reviewing the code :) I am marking this BLOCKED, because of the dependencies. As soon as those have moved forward, this can go back to signed off. |